Skip to content

[OPTIMIZATION] Use a cache when building using functions - #520

Merged
AbnormalPoof merged 2 commits into
FunkinCrew:developfrom
nykwono:use-a-cache-for-using
Sep 28, 2026
Merged

AbnormalPoof merged 2 commits into
FunkinCrew:developfrom
nykwono:use-a-cache-for-using

Conversation

@nykwono

@nykwono nykwono commented Sep 27, 2026

Copy link
Copy Markdown

The PR explains itself, doing this because since [#509], PolymodScriptClass.buildExtensionFunctionCache is used WAY more often and a cache should generally be used when building function calls.

@NotHyper-474

NotHyper-474 commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Screenshot_2026-09-27-11-19-48-737_com.github.android.png

From the looks of it, the cache has to use something else as the key, 'cause HTML5 ain't having it.

Build Actions are so good :trollface:

@nykwono

nykwono commented Sep 27, 2026

Copy link
Copy Markdown
Author

THANK YOU HTML5 WE LOVE YOU

@nykwono

nykwono commented Sep 27, 2026

Copy link
Copy Markdown
Author

I now know the importance of build actions thank you hyper a million times for implementing them into polymod

@AbnormalPoof
AbnormalPoof merged commit 4611542 into FunkinCrew:develop Sep 28, 2026
9 checks passed
@nykwono
nykwono deleted the use-a-cache-for-using branch September 28, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants