Skip to content

Handle null bytes in cast recordings - #983

Merged
chrismaddalena merged 4 commits into
masterfrom
hotfix/recording-null-bytes
Sep 23, 2026
Merged

chrismaddalena merged 4 commits into
masterfrom
hotfix/recording-null-bytes

Conversation

@chrismaddalena

Copy link
Copy Markdown
Collaborator

Summary

This is a small bug fix release that makes Ghostwriter a little better.

CHANGELOG

[7.2.7] - 22 September 2026

Fixed

  • Fixed Asciinema recording uploads containing null characters that could cause the recording save transaction to fail.

Copilot AI lite review requested due to automatic review settings September 22, 2026 23:46
@augmentcode

augmentcode Bot commented Sep 22, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This hotfix prepares Ghostwriter 7.2.7 for release.

Changes:

  • Sanitizes decoded NUL characters from asciicast input/output event text before storing searchable recording text.
  • Adds parser-level and standard upload regression coverage for escaped \u0000 event data.
  • Updates the changelog, application version, and release date for the 22 September 2026 release.
Technical Notes: The uploaded cast file remains unchanged; only the derived PostgreSQL-backed search text is sanitized.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved blocking issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Fixes Asciinema recording uploads containing null bytes that could prevent saving.

Changes:

  • Strips NUL bytes from extracted recording text.
  • Adds utility and upload regression tests.
  • Updates release metadata and changelog to 7.2.7.
File Description
VERSION Updates release version metadata.
ghostwriter/​oplog/​utils.py Sanitizes extracted event text.
ghostwriter/​oplog/​tests/​test_views.py Tests NUL-containing uploads.
ghostwriter/​oplog/​tests/​test_utils.py Tests NUL removal.
config/​settings/​base.py Updates application version metadata.
CHANGELOG.md Documents the fix.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@chrismaddalena
chrismaddalena merged commit a139cce into master Sep 23, 2026
10 checks passed
@chrismaddalena
chrismaddalena deleted the hotfix/recording-null-bytes branch September 23, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants