Handle null bytes in cast recordings - #983
Merged
Merged
Conversation
🤖 Augment PR SummarySummary: This hotfix prepares Ghostwriter 7.2.7 for release.
🤖 Was this summary useful? React with 👍 or 👎 |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Fixes Asciinema recording uploads containing null bytes that could prevent saving.
Changes:
- Strips NUL bytes from extracted recording text.
- Adds utility and upload regression tests.
- Updates release metadata and changelog to 7.2.7.
| File | Description |
|---|---|
VERSION |
Updates release version metadata. |
ghostwriter/oplog/utils.py |
Sanitizes extracted event text. |
ghostwriter/oplog/tests/test_views.py |
Tests NUL-containing uploads. |
ghostwriter/oplog/tests/test_utils.py |
Tests NUL removal. |
config/settings/base.py |
Updates application version metadata. |
CHANGELOG.md |
Documents the fix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a small bug fix release that makes Ghostwriter a little better.
CHANGELOG
[7.2.7] - 22 September 2026
Fixed