[Grufoony]

No description provided.

[claude]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

[codecov]

Codecov Report

❌ Patch coverage is 73.14815% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.12%. Comparing base (dc3999b) to head (b4f5d5a).

Files with missing lines	Patch %	Lines
src/dsf/mobility/RoadNetwork.cpp	65.47%	58 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
- Coverage   95.13%   95.12%   -0.02%     
==========================================
  Files          64       65       +1     
  Lines        9823     9775      -48     
  Branches     1161     1169       +8     
==========================================
- Hits         9345     9298      -47     
+ Misses        451      450       -1     
  Partials       27       27              

Flag	Coverage Δ
unittests	95.12% <73.14%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Benchmark comparison

✅ No performance regressions detected.

dc3999b6ff5a9b7e3e89d86a4fcf2770a1a8b3df → b4f5d5ae3630893de1db7255250fecf6869e7250 · tolerance ±10% · α = 0.05 · regressions below 5 ns are not flagged

🟢 improvement: 3 · ⚪ within noise: 84

Benchmark	Base	Head	Δ	p-value	Status
BM_CoilStreet_AddAgent	97.6 ns	34.2 ns	-64.9%	0.000	🟢 improvement
BM_Street_AddAgent	87.1 ns	35.5 ns	-59.2%	0.000	🟢 improvement
BM_RoadNetwork_NodesLooping	157 µs	136 µs	-13.4%	0.006	🟢 improvement

All benchmarks (87)

Benchmark	Base	Head	Δ	p-value	Status
BM_Agent_ConstructionRandom	9 ns	8.94 ns	-0.7%	0.023	⚪ within noise
BM_Agent_ConstructionWithItinerary	25.6 ns	25.1 ns	-1.9%	0.023	⚪ within noise
BM_Agent_ConstructionWithTrip	12.2 ns	12.2 ns	-0.0%	0.665	⚪ within noise
BM_Agent_Getters	1.04 ns	1.03 ns	-0.8%	0.795	⚪ within noise
BM_Agent_IncrementDistance	0.47 ns	0.472 ns	+0.5%	0.214	⚪ within noise
BM_Agent_Itinerary	0.242 ns	0.24 ns	-0.8%	0.175	⚪ within noise
BM_Agent_Reset	0.118 ns	0.118 ns	-0.3%	0.078	⚪ within noise
BM_Agent_SetFreeTime	5.46e-10 ns	5.66e-10 ns	+3.7%	0.751	⚪ within noise
BM_Agent_SetNextStreetId	5.66e-10 ns	5.46e-10 ns	-3.6%	0.664	⚪ within noise
BM_Agent_SetSpeed	5.61e-10 ns	5.41e-10 ns	-3.5%	0.840	⚪ within noise
BM_Agent_SetSrcNodeId	5.51e-10 ns	5.61e-10 ns	+1.8%	0.488	⚪ within noise
BM_Agent_SetStreetId	0.118 ns	0.118 ns	-0.5%	0.175	⚪ within noise
BM_Agent_Trip	10.3 ns	10.3 ns	-0.2%	0.977	⚪ within noise
BM_Agent_UpdateItinerary	6.51e-10 ns	5.7e-10 ns	-12.4%	1.000	⚪ within noise
BM_CoilStreet_AddAgent	97.6 ns	34.2 ns	-64.9%	0.000	🟢 improvement
BM_CoilStreet_Dequeue	2.24e-09 ns	1.6e-09 ns	-28.4%	0.751	⚪ within noise
BM_CoilStreet_MeanFlow	0.235 ns	0.236 ns	+0.6%	0.583	⚪ within noise
BM_FirstOrderDynamics_AddAgents_RandomODs/agents:1000	565 µs	552 µs	-2.3%	0.371	⚪ within noise
BM_FirstOrderDynamics_AddAgents_RandomODs/agents:10000	5.76 ms	5.62 ms	-2.4%	0.141	⚪ within noise
BM_FirstOrderDynamics_Empty_Evolve	384 µs	388 µs	+1.0%	1.000	⚪ within noise
BM_FirstOrderDynamics_Evolve_ConstantSpeed/agents:5000	604 µs	583 µs	-3.5%	0.237	⚪ within noise
BM_FirstOrderDynamics_Evolve_DataCollection/agents:5000	6.58 ms	6.65 ms	+1.1%	0.624	⚪ within noise
BM_FirstOrderDynamics_Evolve_ODs/agents:1000	432 µs	427 µs	-1.2%	0.583	⚪ within noise
BM_FirstOrderDynamics_Evolve_ODs/agents:10000	718 µs	796 µs	+10.9%	0.194	⚪ within noise
BM_FirstOrderDynamics_Evolve_ODs/agents:5000	603 µs	566 µs	-6.2%	0.341	⚪ within noise
BM_FirstOrderDynamics_Evolve_Random/agents:5000	630 µs	624 µs	-1.0%	0.665	⚪ within noise
BM_FirstOrderDynamics_Evolve_TransitionMatrix/agents:5000	617 µs	626 µs	+1.5%	0.977	⚪ within noise
BM_FirstOrderDynamics_UpdatePaths/destinations:10	79 ms	71.6 ms	-9.3%	0.004	⚪ within noise
BM_FirstOrderDynamics_UpdatePaths/destinations:100	662 ms	639 ms	-3.5%	0.470	⚪ within noise
BM_Intersection_AddAgentWithAngle	39.7 ns	39.2 ns	-1.2%	0.436	⚪ within noise
BM_Intersection_AddAgentWithoutAngle	40.7 ns	40.3 ns	-0.9%	0.795	⚪ within noise
BM_Intersection_AddStreetPriority	18.7 ns	18.7 ns	-0.1%	0.544	⚪ within noise
BM_Intersection_Construction	4.75 ns	4.74 ns	-0.2%	0.751	⚪ within noise
BM_Intersection_ConstructionWithPoint	5.02 ns	4.97 ns	-0.9%	0.795	⚪ within noise
BM_Intersection_Density	0.944 ns	0.942 ns	-0.3%	0.583	⚪ within noise
BM_Intersection_IsFull	0.238 ns	0.239 ns	+0.6%	0.707	⚪ within noise
BM_Intersection_SetStreetPriorities	25.9 ns	25.7 ns	-1.1%	0.665	⚪ within noise
BM_Intersection_nAgents	0.118 ns	0.118 ns	+0.4%	0.470	⚪ within noise
BM_Point_Haversine	37.2 ns	37.5 ns	+0.7%	0.194	⚪ within noise
BM_Point_ParseWKT	281 ns	287 ns	+2.2%	0.000	⚪ within noise
BM_PolyLine_FormatWKT/2	258 ns	261 ns	+0.9%	0.046	⚪ within noise
BM_PolyLine_FormatWKT/50	6.08 µs	6.12 µs	+0.6%	0.061	⚪ within noise
BM_PolyLine_ParseWKT/2	738 ns	736 ns	-0.4%	0.583	⚪ within noise
BM_PolyLine_ParseWKT/50	16.1 µs	16.2 µs	+0.6%	0.214	⚪ within noise
BM_RoadNetwork_AddEdge	450 ns	478 ns	+6.1%	0.931	⚪ within noise
BM_RoadNetwork_AddNode	51.8 ns	51.9 ns	+0.2%	0.885	⚪ within noise
BM_RoadNetwork_AdjustNodeCapacities	245 µs	245 µs	-0.2%	0.665	⚪ within noise
BM_RoadNetwork_AllEdgePathsTo	8.13 ms	8.79 ms	+8.0%	0.885	⚪ within noise
BM_RoadNetwork_AllPathsTo	4.03 ms	3.97 ms	-1.4%	0.470	⚪ within noise
BM_RoadNetwork_AutoAssignRoadPriorities	1.4 ms	1.38 ms	-1.0%	0.035	⚪ within noise
BM_RoadNetwork_CSVImport	830 µs	840 µs	+1.2%	0.214	⚪ within noise
BM_RoadNetwork_CSVImport_Forli	270 ms	272 ms	+1.0%	0.885	⚪ within noise
BM_RoadNetwork_EdgeRandomAccess	15.9 ns	16 ns	+0.6%	0.341	⚪ within noise
BM_RoadNetwork_EdgesLooping	431 µs	431 µs	-0.0%	0.795	⚪ within noise
BM_RoadNetwork_GeoJSONImport	300 µs	292 µs	-2.9%	0.035	⚪ within noise
BM_RoadNetwork_NodeRandomAccess	14.2 ns	13.2 ns	-7.1%	0.003	⚪ within noise
BM_RoadNetwork_NodesLooping	157 µs	136 µs	-13.4%	0.006	🟢 improvement
BM_RoadNetwork_ShortestPath	5.01 ms	4.86 ms	-3.0%	0.237	⚪ within noise
BM_RoadNetwork_StreetLookup	30.8 ns	30.5 ns	-0.9%	0.371	⚪ within noise
BM_Roundabout_Construction	18.1 ns	18.1 ns	-0.0%	0.885	⚪ within noise
BM_Roundabout_ConstructionWithPoint	18.4 ns	18.4 ns	-0.2%	0.931	⚪ within noise
BM_Roundabout_Density	0.941 ns	0.942 ns	+0.2%	0.507	⚪ within noise
BM_Roundabout_Dequeue	47.4 ns	46.7 ns	-1.5%	0.023	⚪ within noise
BM_Roundabout_Enqueue	85.8 ns	84.3 ns	-1.8%	0.840	⚪ within noise
BM_Roundabout_IsFull	0.67 ns	0.675 ns	+0.9%	0.795	⚪ within noise
BM_Street_AddAgent	87.1 ns	35.5 ns	-59.2%	0.000	🟢 improvement
BM_Street_Construction	60.3 ns	58.6 ns	-2.8%	0.002	⚪ within noise
BM_Street_Density	2.14 ns	2.16 ns	+0.8%	0.795	⚪ within noise
BM_Street_Dequeue	2.02e-09 ns	1.97e-09 ns	-2.7%	0.603	⚪ within noise
BM_Street_Enqueue	2.02e-09 ns	2.2e-09 ns	+9.2%	0.773	⚪ within noise
BM_Street_SetLaneMapping	1.7 ns	1.7 ns	-0.0%	0.624	⚪ within noise
BM_Street_nAgents	1.9 ns	1.91 ns	+0.5%	1.000	⚪ within noise
BM_Street_nExitingAgents	2.18 ns	2.18 ns	-0.0%	0.840	⚪ within noise
BM_Street_nMovingAgents	0.237 ns	0.236 ns	-0.3%	0.583	⚪ within noise
BM_TrafficLight_Construction	6.34 ns	6.37 ns	+0.5%	0.214	⚪ within noise
BM_TrafficLight_ConstructionWithPoint	6.86 ns	6.95 ns	+1.3%	0.403	⚪ within noise
BM_TrafficLight_IncreasePhases	178 ns	226 ns	+26.7%	0.751	⚪ within noise
BM_TrafficLight_IsGreen	3.59 ns	3.61 ns	+0.4%	0.795	⚪ within noise
BM_TrafficLight_MeanGreenTime	44.2 ns	44.1 ns	-0.2%	0.436	⚪ within noise
BM_TrafficLight_OperatorIncrement	2.57 ns	2.58 ns	+0.3%	0.795	⚪ within noise
BM_TrafficLight_ResetCycles	21.1 ns	21.4 ns	+1.6%	0.078	⚪ within noise
BM_TrafficLight_SetComplementaryCycle	368 ns	369 ns	+0.3%	0.707	⚪ within noise
BM_TrafficLight_SetCycle	96.9 ns	98.8 ns	+2.0%	0.371	⚪ within noise
BM_TrajectoryCollection_Filter/100	6.7 ms	6.68 ms	-0.3%	0.403	⚪ within noise
BM_TrajectoryCollection_Filter/1000	76 ms	75 ms	-1.3%	0.214	⚪ within noise
BM_TrajectoryCollection_FromDataframe/100	2.2 ms	2.21 ms	+0.2%	0.707	⚪ within noise
BM_TrajectoryCollection_FromDataframe/1000	24.8 ms	24.6 ms	-0.6%	0.507	⚪ within noise