Repository navigation
Conversation
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
HarshCasper
requested changes
Mar 3, 2022
HarshCasper
left a comment
HarshCasper
left a comment
Owner
There was a problem hiding this comment.
Can you add support for CSV & JSON as well with the output piped to a separate file possibly? It will help in situations where a lot of data is to be saved and following a terminal output might not be very conducive.
HarshCasper
added
PR:Reviewed
Author
|
Okay I will see |
Author
|
@HarshCasper I have to see but you can merge it now |
Owner
|
@casmpy That's not how it works — PRs that are reviewed should have those changes that are being requested by the maintainers. Otherwise, it won't make any sense to merge multiple PRs for the same stuff over and over again. If you are not willing to work on the changes, feel free to close the PR. |
Author
|
Okay I will do it
…On Fri, Mar 4, 2022 at 10:28 AM Harsh Mishra ***@***.***> wrote:
@casmpy <https://github.com/casmpy> That's not how it works — PRs that
are reviewed should have those changes that are being requested by the
maintainers. Otherwise, it won't make any sense to merge multiple PRs for
the same stuff over and over again. If you are not willing to work on the
changes, feel free to close the PR.
—
Reply to this email directly, view it on GitHub
<#1307 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APLCQISCD4I5YDFWVKGJNJTU6GKALANCNFSM5PYFXGFQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1291
Added this script in BASH file