Use InfluxDB v3 API for analytics reporting - #23620
Open
SMillerDev wants to merge 1 commit into
Open
Conversation
MikeMcQuaid
reviewed
Aug 23, 2026
SMillerDev
force-pushed
the
SMillerDev-patch-1
branch
2 times, most recently
from
August 23, 2026 11:55
ca4a36c to
1ed254e
Compare
SMillerDev
marked this pull request as ready for review
August 23, 2026 11:56
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Homebrew鈥檚 analytics reporting to use the InfluxDB v3 line-protocol write endpoint in Utils::Analytics, aligning the client with a newer ingestion API.
Changes:
- Switch analytics write URL from
/api/v2/writeto/api/v3/write_lpwith updated query parameters.
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
SMillerDev
commented
Aug 23, 2026
SMillerDev
force-pushed
the
SMillerDev-patch-1
branch
2 times, most recently
from
August 24, 2026 13:05
d361df2 to
861f58b
Compare
Member
Author
|
Split it out to: #23639 |
Member
|
Same deal: Thanks! Can you confirm you've run this locally with export HOMEBREW_ANALYTICS_DEBUG=1 and it produces identical output (bar the URL) to the previous approach? |
SMillerDev
force-pushed
the
SMillerDev-patch-1
branch
from
August 27, 2026 09:40
861f58b to
c8d135d
Compare
Member
Author
|
The analytics still works fine and has identical output. I will wait with the merge until after the next release though, to make sure we don't change too much in one go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?This makes sure we're using the most modern API to write analytics data. Just to keep up to date.
TODO: