Repository navigation
do not load local files for async xhr if file protocol is not allowed - #1185
Merged
Merged
Conversation
rbri
reviewed
Nov 3, 2026
| fireJavascriptEvent(Event.TYPE_LOAD_END); | ||
| return; | ||
| } | ||
| else { |
Member
There was a problem hiding this comment.
lets drop the else, we have the return
Member
There was a problem hiding this comment.
to be clear, only the else not the whole throw ;-)
Contributor
Author
There was a problem hiding this comment.
Done, dropped just the else. The throw stays for the sync case.
Member
|
maybe you can also a an entry to the changes.xml |
Vidya-m78
force-pushed
the
xhr-async-local-file-check
branch
from
November 6, 2026 08:11
0deb496 to
d3ceac0
Compare
Contributor
Author
|
Added a changes.xml entry under 5.8.0. Rebased on master too, since the 5.8.0 section wasn't on my branch yet. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Async XMLHttpRequest ignores the local resource check
When
isFileProtocolForXMLHttpRequestsAllowed()is false (the default),doSend()throws for a sync request to afile:url, but for an async request it only firesreadystatechange/error/loadendand then falls through to the normal send. The file is loaded anyway and the page gets readyState 2/3/4 with the fullresponseText, so a page opened from disk can read any other local file.sendLocalFileAsyncNotAllowedfails on master (629 bytes of the file are returned after the error event) and passes with the addedreturn.