Add CIP-179 v5 linked survey linking and voting - #4184
Conversation
|
Tagging @spannercode @mesudip and @bosko-m for review if possible 馃檹 |
|
83a9678 |
Unwrap label 17 from the singleton metadata map stored by db-sync, while preserving compatibility with already-extracted payloads. Reject maps that do not contain the integer label 17. Read auxiliary data back from the unsigned transaction when assembling the signed transaction. CSL consumes the original auxiliary-data object in Transaction.new; reusing it silently dropped the metadata while retaining its hash in the transaction body. Add independent CBOR fixtures and CardanoProvider regression tests with real coin selection, serialization and signatures. Cover public/sealed survey votes, unrelated/empty/absent metadata, certificate and proposal transactions, and wallet rejection. Leave feature flags unchanged. Validation: 235 frontend tests pass with TZ=UTC; frontend type check, lint and production build pass. Independent cross-repository decoder and actual wallet-callback checks pass. Live Preview acceptance remains pending redeployment.
|
@kusssal apologies for the delay. I just pushed an update to fix a CBOR decoding issue in part of the code I introduced (also in IntersectMBO/govtool-voting-pillar#28). I was looking into the example you deployed at https://pr-4184.dev.gov.tools/ for testing, but it appears the feature flag isn't enabled. Is it possible you can update to the latest commit in this PR and then re-deploy with the feature flag injected through the container entrypoint and enabled? If so, I would be happy to test it with live CIP-179 surveys on Preview myself. |
|
Apologies, but could you pull the latest commit and then redeploy the updated frontend and backend with I was testing the latest deployment and discovered several isseus: Malformed survey presentation data that could break rendering, oversized/stalled downloads, missing expiry and index validation, and clearing optional answers incorrectly blocking submission. All of these are fixed in the latest commit and I am now creating a CIP-179 survey linked to a governance action on Preview for further testing. |
|
Hey @Cerkoryn ,the latest commit is now deployed, with VITE_IS_CIP179_ENABLED=true |
|
@kusssal thank you for your patience 馃檹 I successfully tested the deployed CIP-179 public survey-response flow on Preview: transaction. The survey answers were correctly encoded, with valid constraints, survey linkage, credential proof, and signatures. The governance vote and rationale anchor were also preserved correctly. I did push a small numeric-input fix that is mostly a cosmetic change in the UI. Previously, the fields visually accepted text even though invalid answers already blocked submission. They now reject nonnumeric input and display clear bounds/step errors while retaining GovTool鈥檚 styling. From this testing, I would feel comfortable merging if you are. Alternatively, we can re-deploy one more time if you鈥檇 prefer to validate the numeric-input fix first. |
Preserve upstream dependency upgrades and form typings alongside CIP-179. Regenerate the frontend lockfile and update the wallet test to mock react-router.
a5f5829 to
6196f61
Compare
|
Thanks! @Cerkoryn ,The latest commit has been deployed and and I also successfully completed the CIP-179 flow on Preview: transaction. Before merging, could you document the relevant scenarios using our user-story testing format and add corresponding Playwright tests? With that coverage in place, we鈥檒l feel comfortable merging the PR. |
|
@kusssal how is that looking for you? |
|
@Cerkoryn Thanks for adding the user stories and Playwright coverage.Looks good , ready to merge |
|
@Cerkoryn Thanks again for the contribution. As we are migrating the backend from Haskell to TypeScript, I鈥檇 really value your feedback: how did you find making the backend changes in Haskell for this feature? Were there any parts that felt particularly difficult, slow, or hard to validate that we should improve as part of the TypeScript migration? |
|
@kusssal actually the Haskell changes were quite difficult for me and I could not have done them without the help of AI and significant trial-and-error testing 馃槄 I don't have much experience with Haskell or functional programming, but Typescript is much more familiar and something that I have worked a lot with. I think simplifying the development stack into Typescript as much as possible would be a huge step in the right direction. |
Summary
Supersedes #4152 with an implementation based on the stabilized CIP-179 v5 specification and the published
cip-179package from @mpizenberg's Tessara.This PR focuses on linking, rendering, and submitting survey responses. Tally calculation and results display from the previous proposal are left out of scope for simplicity.
List of changes
VITE_IS_CIP179_ENABLEDVerification
Checklist
I was unfortunately unable to build all of the necessary dependencies to validate all of the changes. But I was able to build the storyboard and visually inspect some example surveys that were attached to governance actions. If this PR passes validation and we can get it merged into https://govtool-preview.cardanoapi.io/ at least, then I would be happy to do some conformance testing of my own with real surveys that are live on Preview and compare them against other tools' CIP-179 implementations.
This PR was constructed with heavy assistance from GPT-5.6 Sol High and I did my best to validate what I could locally. My apologies for not being able to test the entire end-to-end flow however 馃檹