ci: avoid binaries artifact name collision in the nightly dispatcher - #3553
Merged
Merged
Conversation
Both reusable workflows uploaded a 'mithril-binaries' artifact in the same run and the e2e jobs could download the backward compatibility one.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
Pull request overview
This PR prevents nightly workflow artifact-name collisions by assigning unique names to each binaries artifact.
Changes:
- Renamed the E2E artifact and download reference.
- Renamed the backward-compatibility artifact and download reference.
File summaries
| File | Description |
|---|---|
.github/workflows/test-e2e.yml |
Uses the unique mithril-binaries-e2e artifact name. |
.github/workflows/backward-compatibility.yml |
Uses the unique mithril-binaries-backward-compatibility artifact name. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Test Results 5 files ± 0 221 suites ±0 50m 27s ⏱️ - 1h 12m 59s Results for commit 251a333. ± Comparison against base commit f7f05f6. This pull request removes 58 tests. |
Alenar
approved these changes
Sep 18, 2026
jpraynaud
deleted the
jpraynaud/fix-nightly-artifacts-race-condition
branch
September 18, 2026 09:50
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a fix for the intermittent failures of the end-to-end jobs of the nightly dispatcher on the
Prepare binariesstep.The
test-e2eandbackward-compatibilityreusable workflows both uploaded an artifact namedmithril-binariesin the same run, andactions/download-artifactsilently resolves a duplicated name to the artifact with the highest id, so the e2e jobs could receive the backward compatibility layout which has nomithril-aggregatorat its root.test-e2eworkflow tomithril-binaries-e2ebackward-compatibilityworkflow tomithril-binaries-backward-compatibilityPre-submit checklist