Skip to content

ci: avoid binaries artifact name collision in the nightly dispatcher - #3553

Merged
jpraynaud merged 1 commit into
mainfrom
jpraynaud/fix-nightly-artifacts-race-condition
Sep 18, 2026
Merged

jpraynaud merged 1 commit into
mainfrom
jpraynaud/fix-nightly-artifacts-race-condition

Conversation

@jpraynaud

@jpraynaud jpraynaud commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

Content

This PR includes a fix for the intermittent failures of the end-to-end jobs of the nightly dispatcher on the Prepare binaries step.

The test-e2e and backward-compatibility reusable workflows both uploaded an artifact named mithril-binaries in the same run, and actions/download-artifact silently resolves a duplicated name to the artifact with the highest id, so the e2e jobs could receive the backward compatibility layout which has no mithril-aggregator at its root.

  • Rename the binaries artifact of the test-e2e workflow to mithril-binaries-e2e
  • Rename the binaries artifact of the backward-compatibility workflow to mithril-binaries-backward-compatibility

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Both reusable workflows uploaded a 'mithril-binaries' artifact in the same run
and the e2e jobs could download the backward compatibility one.
@jpraynaud jpraynaud self-assigned this Sep 18, 2026
Copilot AI lite review requested due to automatic review settings September 18, 2026 09:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues remain.

Pull request overview

This PR prevents nightly workflow artifact-name collisions by assigning unique names to each binaries artifact.

Changes:

  • Renamed the E2E artifact and download reference.
  • Renamed the backward-compatibility artifact and download reference.
File summaries
File Description
.github/workflows/test-e2e.yml Uses the unique mithril-binaries-e2e artifact name.
.github/workflows/backward-compatibility.yml Uses the unique mithril-binaries-backward-compatibility artifact name.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown

Test Results

     5 files  ± 0     221 suites  ±0   50m 27s ⏱️ - 1h 12m 59s
 3 627 tests  - 58   3 627 ✅  - 58  0 💤 ±0  0 ❌ ±0 
11 765 runs   - 67  11 765 ✅  - 67  0 💤 ±0  0 ❌ ±0 

Results for commit 251a333. ± Comparison against base commit f7f05f6.

This pull request removes 58 tests.
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::index_out_of_bounds
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::index_too_large_for_circuit_range
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::indices_not_increasing
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_merkle_path_mismatch
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_swap_keep_merkle_path
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_wrong_verification_key
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_corrupt_sibling
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_flip_position
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_length_long
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_length_short
…

@jpraynaud
jpraynaud deployed to testing-2-preview September 18, 2026 09:28 — with GitHub Actions Active
@jpraynaud
jpraynaud deployed to testing-preview September 18, 2026 09:28 — with GitHub Actions Active
@jpraynaud
jpraynaud merged commit 6c7862f into main Sep 18, 2026
53 checks passed
@jpraynaud
jpraynaud deleted the jpraynaud/fix-nightly-artifacts-race-condition branch September 18, 2026 09:50

This branch was successfully deployed

2 active deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants