Conversation
Open
Closed
Theres a define in MP that clashes, so it was renamed in MP. Apply this to vanilla too. Co-Authored-By: AntiAnti <17278566+antianti@users.noreply.github.com>
q_shared.h defines "int COM_GetCurrentParseLine( void )" q_shared.cpp implemented "int COM_GetCurrentParseLine( int index )" Fixed now, so function can actually be used. Co-Authored-By: AntiAnti <17278566+antianti@users.noreply.github.com>
Adding mdr structs, one more texture compression algorithm, some zone tags, and SkipBracedSection function Co-Authored-By: AntiAnti <17278566+antianti@users.noreply.github.com>
Cleaned up alot of noise. Code formating will happen in another commit. All work based on: https://github.com/AntiAnti/OpenJK Co-Authored-By: AntiAnti <17278566+antianti@users.noreply.github.com>
To match MP
Chose the SP variant of this to get rid of the void pointer in the struct, so potentially less casting.
cg_showtris 1 shouldnt use depth culling. Had overseen this before.
ifdefed sp / mp differences
The saber marks in SP use some additional scaling and there's some missing parts still. Also fixed incorrect ifdeffed if else constructs.
Added working IsShaking Co-Authored-By: AntiAnti <17278566+antianti@users.noreply.github.com>
Because there's a skyportal in this map, it always culled all the ui elements because they aren't sky surfaces.
when G2_PERFORMANCE_ANALYSIS
Compiles, haven't tested it though
You can now load yavin_swamp again.
…table (#67) * [rend2] Fix gore buffer incorrectly using `glBufferSubData` when immutable * [rend2] Unmap the gore buffer on shutdown when immutable * [rend2] Missing preprocessor guards
* [rend2] Fix dissolve wipes * [rend2] No flags for common dissolve
Don't shuffle lightmap and diffuse stage if the lightmap stage is dependent on the depth write of the first stage.
JOs default is overbrightbits 1. Maps looked very dark without this change.
Adds a cvar to adjust chromatic aberration effect strength when refractive surfaces are drawn.
Those were all put into ubos some time ago, so no need for them to exist anymore in this form.
…FrameNumber Just mark the gore data as cached when its actually drawn.
Doesn't readback the depthbuffer anymore to determain if a flare is visable or not. It will now test depth in the vertex shader that is running for the flare and creates degenerate triangles if it's concidered to be occluded.
It always used the approximation that is used for worldsurfaces instead of using the lightgrid info.
A single break; prevented the code to fill the new indices past the first mergable surface. Also using R_CreateIBO now to get debug names.
This should not have any impact on performance but enables models with alot more bones than it did before. Bones are tightly packed in the ubo, we really just need to stay under the 16KiB UBO block size limit. Fixes: #70
Also makes sure that vertex lit surfaces are assigned to a lightall pass for dlights to work on them reliably.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, this is basically a SP port of rend2. This also puts most of the rend2 code to the shared folder. I also started reducing the differences between SP and MP renderer APIs but I think I can do some more, so just a draft for now. This also needs testing.
Many thanks to @AntiAnti for doing the initial SP port and for the additions to the weather code.