Conversation
Bundle libSDL3.dylib into each generated macOS application bundle to support Homebrew's sdl2-compat packaging. - Install sdl2-compat and SDL3 - Bundle libSDL3.dylib into each .app - Re-sign modified app bundles - Verify bundled SDL runtime during CI
Circa-III
changed the title
Contributor
Author
|
Ditched homebrew altogether for macos SDL2, uses a pinned SDL2 build and bundles that. Tested on macOS 27 Dev Beta 4 on a MacBook Pro (M3 Pro). I do not have an older intel Mac to test with. |
Download the official SDL2 2.32.10 macOS release, extract the architecture-specific dylib from SDL2.framework, and use it for OpenJK and OpenJO builds. Verify that each generated app bundles the correct SDL2 dylib and does not retain Homebrew or CI build-path dependencies.
Download the official SDL2 macOS release, extract the correct architecture-specific dylib, and provide the CMake package metadata OpenJK expects. Keep the existing external handling for zlib, libpng, and libjpeg, verify bundled macOS dependencies, and re-sign the generated application bundles.
Contributor
Author
|
The whole build system is a pain in the ass but I got it. After discussing on discord, some of the devs prefer we pull SDL2 from the release DMG itself rather than build our own every time, so this final version does just that. Tested OpenJK and OpenJO, all should be good now. |
Circa-III
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build SDL2 2.32.10 from source for macOS release builds and bundle it inside each generated application bundle.