Repository navigation
fix(dev): retain reviewed Akaunting 3.2.4 patches and local homologation - #56
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shared local NFS-e development installation now runs Akaunting Core 3.2.4. During homologation, we found three reproducibility and correctness gaps:
AuthenticationExceptionto HTTP 500 instead of 401, obscuring failed authentication and cross-company access denial.Changes
AuthenticationExceptionto HTTP 401 without changing NFS-e business logic.patches/legacy/, outside the runtime's top-levelpatches/*.patchauto-application path. Keep it for audit, not for activation.scripts/apply-core-patches.sh, which verifies the expected Core tag, skips patches already applied, and stops on conflicts rather than overwriting source changes.scripts/verify-local.shfor non-destructive environment, migration, and HTTP checks.throttle:apiremains enabled..local-state/directory insideakaunting-docker.Verification
Local checks completed:
AuthenticationException, 403 for access denial, and 404 for missing routes.These are local homologation results, not a statement that all GitHub Actions checks have passed. The browser scenario also used the Nginx Host-port correction proposed in #55, which is a separate change.
Boundaries and follow-up
Related: #55 covers the independent Nginx Host-header and static-source restrictions.