Skip to content

[stable32] feat: validate CRL when sign a document #5824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitormattos merged 1 commit into from
Nov 27, 2025
Merged

[stable32] feat: validate CRL when sign a document #5824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lib/Service/IdentifyMethod/SignatureMethod/Password.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,18 @@ public function validateToSign(): void {
} catch (InvalidPasswordException) {
throw new LibresignException($this->identifyService->getL10n()->t('Invalid user or password'));
}

$this->validateCertificateRevocation($certificateData);
$this->validateCertificateExpiration($certificateData);
}

private function validateCertificateRevocation(array $certificateData): void {
if (isset($certificateData['crl_validation']) && $certificateData['crl_validation'] !== 'valid') {
throw new LibresignException($this->identifyService->getL10n()->t('Certificate has been revoked'), 400);
}
}

private function validateCertificateExpiration(array $certificateData): void {
if (isset($certificateData['valid_to'])) {
$validTo = \DateTime::createFromFormat('F j, Y, g:i:s A', $certificateData['valid_to']);
if ($validTo === false) {
Expand Down
Loading