Skip to content

fix: handle corrupted signature data #5916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitormattos merged 3 commits into from
Dec 2, 2025
Merged

fix: handle corrupted signature data #5916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ec5e38
fix: handle corrupted signature data in PDF validation
vitormattos Dec 2, 2025
734f1e4
test: add coverage for corrupted signature data handling
vitormattos Dec 2, 2025
a768272
fix: cs
vitormattos Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/Handler/SignEngine/Pkcs12Handler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,17 @@ private function getSignatures($resource): iterable {
rewind($resource);

$signature = stream_get_contents($resource, $signatureLength, $signatureStart);
if ($signature === false) {
yield null;
continue;
}

yield hex2bin($signature);
$decodedSignature = @hex2bin($signature);
if ($decodedSignature === false) {
yield null;
continue;
}
yield $decodedSignature;
}

$this->tempManager->clean();
Expand Down
25 changes: 25 additions & 0 deletions tests/php/Unit/Handler/SignEngine/Pkcs12HandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,31 @@ public function testGetCertificateChainWithInvalidInput(): void {
fclose($invalidResource);
}

public function testGetCertificateChainWithCorruptedSignature(): void {
$handler = $this->getHandler();

$corruptedPdf = "%PDF-1.4\n"
. "1 0 obj<</Type/Sig/ByteRange [0 10 50 10]>>endobj\n"
. "ZZZZZZZZ\n" // Invalid hex data - will cause hex2bin to fail
. str_repeat('x', 100);

$resource = fopen('php://memory', 'r+');
fwrite($resource, $corruptedPdf);
rewind($resource);

$result = $handler->getCertificateChain($resource);

$this->assertIsArray($result);
$this->assertCount(1, $result);
$this->assertArrayHasKey('chain', $result[0]);
$this->assertArrayHasKey('signature_validation', $result[0]['chain'][0]);
$this->assertIsArray($result[0]['chain'][0]['signature_validation']);
$this->assertEquals(3, $result[0]['chain'][0]['signature_validation']['id']); // Digest Mismatch
$this->assertStringContainsString('Digest mismatch', $result[0]['chain'][0]['signature_validation']['label']);

fclose($resource);
}

public function testRealWorldUsagePattern(): void {
$handler = $this->getHandler();

Expand Down
Loading