Repository navigation
[stable32] fix: handle corrupted signature data - #5918
Merged
Merged
Conversation
When processing PDF signatures, hex2bin() and stream_get_contents() can fail and return false when dealing with corrupted or malformed signature data. Previously, this would cause a TypeError when false was passed to processSignature() which expects ?string. Now, invalid signatures are properly reported to users with a 'Digest Mismatch' validation error instead of causing a fatal error. This fix: - Validates hex2bin() return value before yielding - Validates stream_get_contents() return value before processing - Returns null for corrupted signatures which are then reported as invalid - Suppresses expected hex2bin() warnings for non-hexadecimal data Fixes the issue reported where users encountered: TypeError: Argument #2 ($signature) must be of type ?string, false given Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Add test case to verify that PDFs with corrupted signature data (invalid hexadecimal strings) are properly handled and reported to users with appropriate validation errors instead of throwing exceptions. The test verifies: - Corrupted signatures return validation error - Error has correct structure with id and label - Error is identified as 'Digest mismatch' (id: 3) - No fatal errors or exceptions are thrown Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in LibreSign Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #5916