Repository navigation
fix: document not visible after account creation - #5919
Merged
vitormattos merged 5 commits intoDec 2, 2025
Merged
Conversation
When a non-existing user is invited to sign a document via email and creates an account through the sign request link, the document was not appearing in their file list after login. This happened because: - The sign request was created with email as the identifier - After account creation, the system searches for documents using the user's UID (account identifier) - The identifier was never updated from email to account This fix: - Updates the identify method from 'email' to 'account' when a new user is created via createToSign() - Sets the identifier value to the new user's UID - Allows the document to appear correctly in the user's file list Fixes issue reported where users couldn't see documents after account creation despite receiving notifications. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Add integration test to verify that when a non-existing user creates an account through a sign request link, the document appears in their file list. The test verifies: - User can successfully create account via sign request link - Document appears in the file list after login - The identify method is correctly updated to 'account' - The identifier value matches the new user's UID This test would have caught the bug where documents were not visible after account creation. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
backportbot-libresign
Bot
added
the
backport-request
Update AccountServiceTest to include the new IdentifyMethodMapper dependency that was added to AccountService constructor. This fixes the unit test failures caused by the type mismatch error: 'Argument #18 ($identifyMethodMapper) must be of type OCA\Libresign\Db\IdentifyMethodMapper' Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
deleted the
fix/document-not-visible-after-account-creation
branch
December 2, 2025 14:31
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in LibreSign Roadmap
This was referenced Dec 2, 2025
backportbot-libresign
Bot
removed
the
backport-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.