Repository navigation
[stable32] refactor: footer handler reduce coupling - #5989
Merged
Merged
Conversation
- Remove $file property to reduce coupling - Make getMetadata() public and accept File as parameter - Change getFooter() to receive dimensions array instead of File - This allows more flexibility and reduces dependencies Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Update test to pass dimensions array instead of File - All 6 tests passing (27 assertions) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Call getMetadata() before getFooter() - Pass dimensions array to getFooter() instead of File object Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in LibreSign Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #5988