Repository navigation
[stable31] feat: disable identify methods none engine - #6057
Merged
Merged
Conversation
Add setEngine() method to IEngineHandler interface and implement in AEngineHandler to automatically configure identify methods based on certificate engine selection. When engine is 'none', only account identification is enabled since no certificate infrastructure is available for other methods. Related to #5145 Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Add POST /api/v1/admin/certificate/engine endpoint that sets the engine and returns updated identify_methods configuration. This allows frontend to receive processed identify methods data with labels and friendly names after engine changes. Related to #5145 Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Add saveCertificateEngine() action that calls the REST endpoint and updates both engine and identify_methods state reactively. Uses axios promise chain pattern for consistency with existing store actions. Related to #5145 Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Update CertificateEngine component to use store action and emit event after setup check completes. This ensures proper timing for cross-component communication. Related to #5145 Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Add v-if directive to hide IdentificationFactors section when certificate engine is 'none', and watch identifyMethods to ensure UI updates reactively when switching engines. This prevents users from configuring identification methods that require certificate infrastructure. Fixes #5145 Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Add comprehensive test coverage for configureIdentifyMethodsForEngine including edge cases and data provider patterns. Tests validate that 'none' engine correctly configures only account identification with minimal configuration. Related to #5145 Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
The identify_methods array was incorrectly annotated as 'array' which violated OpenAPI documentation standards. Changed to 'array<array<string, mixed>>' to properly represent a list of non-empty objects. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…otation Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in LibreSign Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #6054