Repository navigation
[stable34] fix(validation): open signed PDF by UUID instead of owner node ID - #9135
Merged
Merged
Conversation
Signed-off-by: oPeras1 <hugo.pereira@rnl.tecnico.ulisboa.pt>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
test(validation): wait for signed PDF popup before asserting fallback Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> [skip ci]
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
marked this pull request as ready for review
October 21, 2026 00:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9104 for Nextcloud 34. Fixes #9103.
The automated cherry-pick included Nextcloud 36 Viewer code that cannot run on this stable branch. The follow-up commits adapt it to the supported API:
OCA.Viewer.openWith('pdf', ...)for authenticated users when the native PDF handler is registered./apps/libresign/p/pdf/{uuid}without passing the original file ID to any Viewer/Office handler.Local validation
npm run ts:check)npm run build)main)Historical backport blockers
Frost-PhoenixvsoPeras1). Its DCO check remains unresolved; the six manually added commits across all backports are individually signed and DCO-valid.