Skip to content

[stable34] fix(validation): open signed PDF by UUID instead of owner node ID - #9135

Merged
vitormattos merged 11 commits into
stable34from
backport/9104/stable34
Oct 21, 2026
Merged

vitormattos merged 11 commits into
stable34from
backport/9104/stable34

Conversation

@backportbot-libresign

@backportbot-libresign backportbot-libresign Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Backport of #9104 for Nextcloud 34. Fixes #9103.

The automated cherry-pick included Nextcloud 36 Viewer code that cannot run on this stable branch. The follow-up commits adapt it to the supported API:

  • Use OCA.Viewer.openWith('pdf', ...) for authenticated users when the native PDF handler is registered.
  • Open signed documents through /apps/libresign/p/pdf/{uuid} without passing the original file ID to any Viewer/Office handler.
  • Use the direct URL fallback for anonymous visitors or when the native PDF handler is unavailable. Do not silently swallow Viewer errors.
  • Keep ordinary document opening unchanged.
  • Remove accidental lockfile changes, NC36-only test mocks, and unrelated async caller changes introduced by the automatic backport.
  • Keep validation component regression tests and a Playwright scenario for the anonymous PDF fallback.

Local validation

  • 83 focused Vitest tests passed (Viewer + validation components)
  • TypeScript (npm run ts:check)
  • JavaScript build (npm run build)
  • Playwright test discovery
  • Focused ESLint: existing ESLint 8/flat-config mismatch on this stable branch; GitHub check must be evaluated separately
  • Review current GitHub Actions results (Playwright workflow only targets main)

Historical backport blockers

  • The original contributor commit has mismatched author/sign-off names (Frost-Phoenix vs oPeras1). Its DCO check remains unresolved; the six manually added commits across all backports are individually signed and DCO-valid.
  • This bot-created backport also contains one empty historical commit.
  • No existing commits were rewritten or squashed. Resolve historical DCO separately before merging.

oPeras1 and others added 9 commits October 20, 2026 23:56
Signed-off-by: oPeras1 <hugo.pereira@rnl.tecnico.ulisboa.pt>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
test(validation): wait for signed PDF popup before asserting fallback

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

[skip ci]
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos vitormattos changed the title [stable34] fix(validation): open signed PDF by UUID instead of the owner's nodeIdFixes #9103 [stable34] fix(validation): open signed PDF by UUID instead of owner node ID Oct 21, 2026
@vitormattos
vitormattos marked this pull request as ready for review October 21, 2026 00:15
@vitormattos
vitormattos requested a review from a team as a code owner October 21, 2026 00:15
@vitormattos
vitormattos merged commit 86c199c into stable34 Oct 21, 2026
60 of 61 checks passed
@vitormattos
vitormattos deleted the backport/9104/stable34 branch October 21, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants