Repository navigation
[stable34] fix(validation): base the validation summary on applied signatures only - #9139
Merged
Merged
Conversation
The validation page showed "This document is valid" for a document that nobody has signed yet, and for an envelope where nobody signed. The summary only returned "No digital signatures were found in this document" when the signer list was empty; a pending signer carries no signature data, so none of the error or warning checks matched and the summary fell through to "valid". The summary now considers only the signers who have signed (a signing date or signature validation data). When nobody has signed, it shows the existing "No digital signatures were found" note; otherwise the current checks run on the signed signers only. Fixes #8967 Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: André Maia <andrefnkmm@gmail.com>
…e summary Signed-off-by: André Maia <andrefnkmm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #9009