[vitormattos]

Summary

Simplifies self-signing (#4005) while keeping the standard signing lifecycle and policies.

User journeys

• Sign myself (Nextcloud Files and LibreSign): open the ready-to-sign sidebar, add the current account as signer, and keep Sign document, visible signature positions, and additional signers available. This uses the regular request/signing flow, not the direct endpoint.
• Sign PDF now (LibreSign Files → Request menu; Nextcloud Files → Open in LibreSign sidebar): display a confirmation for the selected PDF with two actionable choices:
  • Sign now uses Click to Sign through POST /ocs/v2.php/apps/libresign/api/v1/sign/direct, then downloads the signed PDF without a visible signature field (an enabled footer policy may still apply).
  • Prepare signing enters the standard request flow and auto-adds the current account as a ready-to-sign signer. In LibreSign, it uploads the selected local PDF, selects it, and opens its sidebar. In Nextcloud Files, it keeps the existing PDF and uses the current sidebar. The user can edit signature positions, add other signers, or use Sign document. Prepare signing does not call the direct endpoint.
• Do not show this confirmation again is per-user and saved only after a successful Sign now. It only skips the confirmation for future explicit Sign PDF now actions, not Sign myself or ordinary requests. Users can re-enable it in LibreSign → Preferences → Signature requests.
• API authorization is independent of the preference: account method/policy and signature-request permission are enforced server-side on every direct call. A user preference must never grant access or disable checks. Uncertain signing outcomes cannot be retried blindly; this convenience endpoint does not implement idempotency keys.
• The initial Request screen and Nextcloud Files context menu have no additional immediate-signing button.

UI comparisons

Visual comparisons: real Playwright screenshots (main vs PR)

Surface	Before (main)	After (this PR)
LibreSign Files — Request menu
Nextcloud Files — PDF menu
Nextcloud Files — LibreSign sidebar
Personal preferences — Signature requests
LibreSign Files — document actions
Add signer dialog

Immediate signing confirmation (appears after selecting a PDF via Sign PDF now, unless dismissed):

Prepare signing from Sign PDF now: real Playwright screenshot of the standard sidebar after selecting Prepare signing, showing the account signer, signature-position editor, and Sign document action.

Regular ready-to-sign sidebars (Sign myself; separate from direct signing):

LibreSign Files	Nextcloud Files

API regression coverage (Behat + PHPUnit)

• Behat HTTP/OCS integration: 18 scenarios / 84 steps passed on isolated Nextcloud 36 with a real signing engine. Includes authentication, manager access, forbidden parameters, invalid payloads, disabled account-signing policy and real PDF signing for Base64, Nextcloud path and node ID.
• Signed PDF verification: checks HTTP 200, Content-Type: application/pdf, attachment filename, Cache-Control: no-store, document UUID header and the embedded PDF /ByteRange.
• PHPUnit: 38 relevant controller/service tests with 181 assertions passed. Contract regression checks validate both checked-in OpenAPI specifications, supported fields, auth scheme, v1 route, binary PDF response, and documented error statuses.
• Quality: PHP syntax check and PHP-CS-Fixer dry run passed on touched PHP files. No production endpoint or workflow change was needed.

Validation

• 163 focused Vue/Vitest tests passed (5 suites; NODE_ENV=test).
• 4/4 real Playwright E2E flows passed on isolated Nextcloud 36: immediate signing/download and guided preparation, both from LibreSign and Nextcloud Files.
• Playwright screenshots above were captured from the actual built branch; no synthetic mockups were used.
• Frontend TypeScript checking, ESLint on touched files, and production Vite build passed.
• Automated GitHub checks for the updated head commit may still be running; this pull request remains in draft pending their completion and review.

[YvesCesar]

@vitormattos

I made a few revisions. Could you take a look?

[YvesCesar]

@vitormattos

I made a few more revisions.

[YvesCesar]

This check breaks the sidebar for signed copies. The record of a signed PDF keeps the nodeId of the original file, so file/list returns the right record for nodeIds[]=<signed copy>, but this condition discards it.

I reproduced it in the browser: after signing, opening *.signed_N.pdf in the LibreSign tab shows an empty sidebar with Add signer, instead of the signer and Validation info. Saving a signer there returns 422, "A completed signer cannot be removed."

Could you remove this check? !files.value[fileId] below is enough for the case I raised. Without these three lines, the signed copy shows correctly again, and the six Sign myself cases and the file switch case keep passing.

The test does not select a different file returned by a filtered refresh would need to go too, or could be replaced by one that opens a signed copy whose record has a different nodeId.

[YvesCesar]

isset($source['base64']) is true for an empty string, but validateInput() ignores empty values, so {"base64": "", "nodeId": 123} passes validation and skips every check below. I reproduced it on this branch:

• Shared PDF, including read-only: the 403 is bypassed. The document is signed, and the call returns 409.
• The user's own file, failed preflight: isset($file['base64']) on line 98 is true, so the cleanup deletes the original file and the folder if it becomes empty.
• base64: 123 or an array: returns 500.

Could you only treat base64 as selected when it isn't empty, and reject non-string values?

if (($source['base64'] ?? '') !== '') {
        return ['base64' => $source['base64']];
}
unset($source['base64']);

if (isset($file['base64']) && !is_string($file['base64'])) {
        throw new LibresignException('Provide exactly one PDF as file.base64, file.nodeId, or file.path.', Http::STATUS_BAD_REQUEST);
}

With this change, the shared cases return 403, the user's file is kept, and non-string values return 400. Please add tests for an empty base64 combined with nodeId and with path.

[YvesCesar]

@vitormattos

I made a few more revisions. I forgot to mention it in the general last review comment.