Repository navigation
ci(i18n): enforce translator hint conventions - #9364
Open
vitormattos wants to merge 5 commits into
Open
vitormattos wants to merge 5 commits into
vitormattos wants to merge 5 commits into
Conversation
Merged
4 tasks done
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
force-pushed
the
fix/translator-hints-policy-20261104
branch
from
November 5, 2026 14:52
6427634 to
fcf0aaa
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply one consistent LibreSign convention for translator hints across the frontend and PHP backend, fix ambiguous translation calls, and prevent repeated or malformed hints in CI.
Depends on #9360. That PR corrects the approval workflow and removes the triplicated hints on the Approved and Pending filters. This follow-up standardizes the rest of the project and protects the convention automatically.
LibreSign convention
// TRANSLATORS Explain the context.in JavaScript, TypeScript and PHP, or<!-- TRANSLATORS Explain the context. -->in Vue templates.TRANSLATORSmarker. This is a LibreSign code-style decision; Nextcloud supports the optional punctuation.t()orn()call. Never repeat hints consecutively above a single translation.Changes
scripts/check-translator-hints.mjsand its existingnpm run lintCI integration to block:TRANSLATORSmarker;src,lib,appinfo,tests, andscripts(excluding the checker's own deliberately malformed test fixtures and generated OpenAPI types).CONTRIBUTING.mdandAGENTS.mdas brief pointers to the canonical developer-manual Translation page, maintained by LibreSign/documentation#124. Remove the duplicated tutorial from the application repository.Documentation dependency: LibreSign/documentation#124 contains the complete contributor explanation, with rendered screenshots and a warning-free Sphinx build. The automated checker stays in this LibreSign application PR.
Validation
node --test scripts/tests/check-translator-hints.test.mjs: 8 tests passed.node scripts/check-translator-hints.mjs: passed across tracked application sources.npm run ts:check: passed.php -lfor each of the five affected PHP files using the Nextcloud development container: passed.npm run lint: passed (pre-existing non-blocking lint warnings only).Scope: Comments, contributor guidance, localization call organization and CI safeguards. No generated translation catalog changes, new dependencies or modifications to signing behavior. No squash or merge requested.