Repository navigation
Dependency injection for lifespan - #37
Merged
ManiMozaffar merged 3 commits intoSep 13, 2026
Merged
ManiMozaffar merged 3 commits into
ManiMozaffar merged 3 commits into
Conversation
ManiMozaffar
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the docs currently suggests that the users should use
lifespaninstead ofOnStartUpandOnShutDownevents, we should also let them define their dependencies through the lifespan.The
OnStartUpandOnShutDownevents are triggers, so the@app.task()would do the injection correctly:aioclock/aioclock/app.py
Line 294 in c943c85
But, lifespan doesn't:
aioclock/aioclock/app.py
Line 334 in c943c85
While fixing the issue, I noticed that there is another issue regarding different versions of
FastDepends. In v2, the parameter name was"dependeny_overrides_provider"and in v3 it changes to"dependeny_provider": Lancetnik/FastDepends@4beac5fwe have defined
"fast-depends>=2.4.0"in the pyproject.toml so we should also consider this. I wrote a helper function for that which inspects theinject()functions parameter.