Conversation
Pulls each resolved service's image, skipping build-only services (no image key) and images already present locally — mirroring the already-present match logic up uses (exact, registry-prefixed, or short reference). Passes the service's platform: through when set. Resolves the project through the shared ComposeProjectOptions (Mcrich23#138) and fails fast on unknown service names per the Mcrich23#139 contract.
Owner
|
Thank you for adding this! Skipping images that already exist means |
This was referenced Sep 9, 2026
Open
…ted services
- Drop the already-present shortcut: refreshing a moving tag like
:latest is the point of an explicit pull (up's implicit pull keeps
the shortcut).
- Resolve ${VAR}/${VAR:-default} placeholders in image references
from the environment file before pulling — a literal ${...} is not
a valid registry reference.
- Pull only the requested services' images: the shared selection
expands depends_on for up's sake, so explicit requests are narrowed
back to the named services, with --include-deps to opt into the
expanded set (matching docker compose pull).
Extracts pullTargets/resolvedImage as pure functions with unit
coverage for dependency narrowing, --include-deps, variable
resolution and defaults, and build-only services.
Contributor
Author
|
Fixed all three:
Also added united tests for each behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls each resolved service's image, skipping build-only services (no image key) and images already present locally — mirroring the already-present match logic up uses (exact, registry-prefixed, or short reference). Passes the service's platform: through when set.
Resolves the project through the shared ComposeProjectOptions (#138) and fails fast on unknown service names per the #139 contract.