[bpepple]

Summary

metron-tagger keyed the shared Redis rate-limit state by a hash of the API token. Each mokkari-based app usually has its own token, so metron-tagger never shared a limit with other apps on the same Metron account. This PR keys it by the Metron username instead, the same way Barda does.

Changes

• talker.py: Talker passes the configured user to RedisRateLimiter, including when authenticating with an API token. If no username is set, it warns and falls back to the local HeaderPacedRateLimiter. Removes _redis_account() and the token hashing.
• cli.py: Switching from password to token auth now keeps metron.user and removes only the password, so migrated users still have the username Redis needs.
• README.md: The Redis FAQ says user is required even with token auth. The section on sharing with other mokkari software now says to use the Metron username as the account.
• Tests: Removed the _redis_account tests. Added a test that a token user's limiter is keyed by username. The no-username test now covers a token with no username, and the CLI migration test expects the username to be kept.

Compatibility with other apps

• Barda: It also keys by the raw username with mokkari's default key_prefix, so both apps use mokkari:ratelimit:{<username>}:* and share one limit.
• Desaad It also keys by the raw username with mokkari's default key_prefix, so both apps use mokkari:ratelimit:{<username>}:* and share one limit.

Summary

metron-tagger keyed the shared Redis rate-limit state by a hash of the API token. Each mokkari-based app usually has its own token, so metron-tagger never shared a limit with other apps on the same Metron account. This PR keys it by the Metron username instead, the same way Barda does.

Changes

• talker.py: Talker passes the configured user to RedisRateLimiter, including when authenticating with an API token. If no username is set, it warns and falls back to the local HeaderPacedRateLimiter. Removes _redis_account() and the token hashing.
• cli.py: Switching from password to token auth now keeps metron.user and removes only the password, so migrated users still have the username Redis needs.
• README.md: The Redis FAQ says user is required even with token auth. The section on sharing with other mokkari software now says to use the Metron username as the account.
• Tests: Removed the _redis_account tests. Added a test that a token user's limiter is keyed by username. The no-username test now covers a token with no username, and the CLI migration test expects the username to be kept.

Compatibility with other apps

• Barda: It also keys by the raw username with mokkari's default key_prefix, so both apps use mokkari:ratelimit:{<username>}:* and share one limit.
• desaad: It also keys by the raw username with mokkari's default key_prefix, so both apps use mokkari:ratelimit:{<username>}:* and share one limit.

Upgrade note

Users who already switched to token auth had user removed from their settings. To use the Redis limiter, they need to add it back to the [metron] section of settings.ini:

[metron]
user = your-metron-username
redis_url = redis://localhost:6379/0