chore: address Copilot review feedback across the field-review PRs

[MichaelLeeHobbs]

Summary

Follow-up to the merged field-review PRs (#25–#30, #32) addressing GitHub Copilot's review comments. Each was triaged against source; the substantive ones have repros/tests.

Substantive

• fix(tokenizer): keep parse() never-throwing and bound nested encapsulated scans (§3) #26 — resource-bound contract gap. The salvaging guard around the fallback addElement could let structureCount exceed maxElements without ever surfacing limit-exceeded when the fallback was the last element read (EOF / just before stopAt). Removed the guard; run()'s recovery call site now catches a limit-exceeded from recoverToFallback and surfaces it as a partial result — consistent with how every other cap trip is reported. Verified: the merged code returned ok/no-error with the cap exceeded; the fix reports limit-exceeded with the pre-limit elements retained.
• fix(writer): validate transfer syntax against pixel-data payload; BE pixel view (D2, §3) #28 — big-endian host. nativePixelDataView hard-coded the host as little-endian. It now byte-swaps when the dataset's order differs from the detected host order, so 16-bit views are correct on a big-endian host too (LE-host behavior unchanged; the BE≡LE fixture test still passes).
• feat(api): flip stopAt default to exclusive; add isDicomError; DX polish (§3) #30 — over-permissive guard. isDicomError now also requires instanceof Error (reliable across the dual ESM/CJS build — both extend the one global Error), so a bare branded plain object is rejected. Test updated to a real cross-build Error carrying the shared brand.

Minor

• Removed a leftover duplicate JSDoc above NATIVE_TRANSFER_SYNTAXES (fix(writer): validate transfer syntax against pixel-data payload; BE pixel view (D2, §3) #28).
• floatStrings/intStrings docs say "absent or empty"; added a NaN-contract test for empty/non-numeric components (feat(api): isValidUid (W7) and bulk multi-value accessors (W13) #32).
• isValidUid doc references DicomDataSet.string() concretely (feat(api): isValidUid (W7) and bulk multi-value accessors (W13) #32).
• Disambiguated field-review W7/W13 from the adversarial-review W-series in PLAN (feat(api): isValidUid (W7) and bulk multi-value accessors (W13) #32).
• D1 test title notes the input is conformant (fix(tokenizer): finalize a defined-length item at its bound before peeking (D1) #25).

Not changed (false positive)

Copilot flagged the unique symbol annotation on errors.ts as likely to fail typechecking. It does not — it compiles clean on ts7 + typescript@6, and the annotation is required for the computed-key brand field (a plain symbol triggers TS1166, as this PR's own test churn confirmed).

Verification

Full suite 717 passed / 4 skipped; lint, typecheck, format, attw all clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_015fdQkZCohJHGNBjEMbk8ga

[Copilot]

Pull request overview

Follow-up maintenance PR that incorporates previously raised review feedback across the MedFusion field-review PR series, primarily tightening resource-bound error surfacing, endianness correctness, and cross-build error-guard behavior while updating tests/docs to match the refined contracts.

Changes:

• Tokenizer recovery now correctly surfaces limit-exceeded as a partial-result error even when triggered during sequence fallback recovery (and even when it’s the last element read).
• Native pixel-data typed views now byte-swap when dataset byte order differs from the detected host byte order (supporting big-endian hosts).
• isDicomError is hardened to require instanceof Error plus the shared Symbol.for brand; tests and docs updated accordingly.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/valueParsers.ts	Clarifies isValidUid doc reference to DicomDataSet.string() semantics.
src/tokenizer.ts	Catches limit-exceeded thrown during fallback recovery and returns it as a partial-result error (preserves never-throws contract).
src/tokenizer.test.ts	Updates D1 test labeling and adds/adjusts regression coverage for the fallback+maxElements partial-result behavior.
src/pixelData.ts	Detects host endianness and swaps 16-bit native pixel samples when dataset order differs from host.
src/parse.ts	Removes a duplicate/leftover JSDoc line above native transfer syntax documentation.
src/errors.ts	Tightens isDicomError guard to require instanceof Error in addition to the brand symbol.
src/errors.test.ts	Updates guard tests to reject branded plain objects and accept cross-build Error + brand.
src/dataSet.ts	Updates floatStrings/intStrings docs to match the “absent or empty” accessor contract.
src/dataSet.test.ts	Adds coverage for NaN behavior on empty/non-numeric bulk numeric components (positional alignment).
PLAN.md	Disambiguates field-review W7/W13 vs adversarial-review W-series references.
CHANGELOG.md	Updates release notes to reflect the new “catch at call site” behavior for fallback limit surfacing.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.