Repository navigation
Conversation
Remove `suite`/`new_suite` from ReversionConfig and the `--suite` flags of `reversion` and `persist`. They never changed the `Suite` field (the help said they did). They did two other things: - rewrote a `Distribution:` line, which binary packages do not have; - replaced the whole changelog with one new entry naming the channel and the current time, so the package bytes depended on the channel and on when the reversion ran, and the package history was lost. A reversion now changes `Package` and `Version` only. The channel is the apt component (deb-s3 `--component`/`--suite` in publish, which stays), not part of the package. This follows MinaProtocol/mina#19996, which stopped writing `Suite` into the control file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MinaProtocol/mina#19996 stopped writing
Suiteinto the control file: the channel is the apt component, not part of the package, so the same.debcan move between channels unchanged. The reversion inrelease-managerstill took a channel (suite,new_suite). It never changedSuite(thereversion --suitehelp said it did), but it did two other things with it:Distribution:line. Binary packages do not have this field, so this did nothing;/usr/share/doc/<pkg>/changelog.Debian.gzorchangelog.gz, replaced the whole changelog with one new entry that names the channel and the current time. The package bytes then depended on the channel and on when the reversion ran, and the package history was lost.What changes
ReversionConfigandreversion_debian_packagelosesuiteandnew_suite. A reversion changesPackageandVersiononly.Distribution:rewrite and the changelog rewrite are removed.reversion --suiteandpersist --suiteare removed. Nothing in this repo or inmina(compatible) passes them.promoteandpublish-from-cachecall the reversion without the channel. They still use the channel for publishing and verification.publishstill gives the channel todeb-s3as--componentand--suite. That--suiteis the repository Release file, which is correct, so it stays.Testing
cargo test: 128 pass (127 onmain, plustest_control_content_keeps_every_other_field:SuiteandDistributionstay as they are, onlyVersionchanges).cargo fmt --checkclean;cargo clippy --all-targetsgives the same 12 warnings asmain.Suite: unstableand achangelog.Debian.gz, reversioned 1.0.0 → 2.0.0, compared withdeb-toolkit diff:mainwith--suite stable: the changelog content changes to a single entrymina-x (2.0.0) stable; …;Suitestaysunstable.Suitestaysunstable; the only control change isVersion.Not covered (found while testing, not changed here)
dpkg-deb --build, withoutfakeroot. Run as a normal user, every file in the new package is owned by that user (seen:root:root→darek:darek). As root in CI this does not show.mainhas the same behavior.persist --new-versioncannot work: it runsbash -c "reversion …", and noreversioncommand exists any more. Alsoextract_version_from_debreturns the architecture, not the version, for a<name>_<version>_<arch>.debname. Nothing callspersist, so this PR only removes its--suite.🤖 Generated with Claude Code