Skip to content

perf: readZString optimization #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SimplisticMind wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: readZString optimization #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/bsatypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ void writeBString(fstream& file, const std::string& string)
std::string readZString(fstream& file)
{
char buffer[FILENAME_MAX];
memset(buffer, '\0', FILENAME_MAX);
if (!file.getline(buffer, FILENAME_MAX, '\0')) {
throw data_invalid_exception("can't read from bsa");
}
return std::string(buffer);
// gcount() includes the extracted '\0' delimiter, so the name is one shorter
return std::string(buffer, static_cast<size_t>(file.gcount()) - 1);
}

void writeZString(fstream& file, const std::string& string)
Expand Down
Loading