Skip to content

Add a override function in score for via backwards - #89

Merged
MrMicky-FR merged 11 commits into
MrMicky-FR:masterfrom
Dominilk01:score-override
Sep 21, 2026
Merged

MrMicky-FR merged 11 commits into
MrMicky-FR:masterfrom
Dominilk01:score-override

Conversation

@Dominilk01

Copy link
Copy Markdown
Contributor

tested on :

This server is running Paper version 26.2-92-main@0a99345 (2026-08-02T20:33:44Z) (Implementing API version 26.2.build.92-stable)
You are running the latest version
Previous version: 26.2-60-1cb58fb (MC: 26.2)

with viaversion viabackward 5.11.0
1.20.2 and 1.20.4

        final FastBoard board = new FastBoard(event.getPlayer()) {
            @Override
            public boolean hasCustomScores() {
                return PacketEvents.getAPI().getPlayerManager().getClientVersion(event.getPlayer()).getProtocolVersion() >= ClientVersion.V_1_20_3.getProtocolVersion();
            }
        };
2026-08-04_23-33-58.mp4

@Dominilk01 Dominilk01 changed the title Add a override function for via backwards [WIP] Add a override function for via backwards Aug 4, 2026
@Dominilk01 Dominilk01 changed the title [WIP] Add a override function for via backwards [WIP missing update readme.md] Add a override function for via backwards Aug 4, 2026
@MrMicky-FR MrMicky-FR changed the title [WIP missing update readme.md] Add a override function for via backwards Add a override function for via backwards Aug 8, 2026
@MrMicky-FR
MrMicky-FR marked this pull request as draft August 8, 2026 19:29
@MrMicky-FR

Copy link
Copy Markdown
Owner

Thank you! Just for info, I marked this as a draft until the missing changes are ready :)

@Dominilk01
Dominilk01 marked this pull request as ready for review August 10, 2026 20:48
@Dominilk01 Dominilk01 changed the title Add a override function for via backwards Add a override function in score for via backwards Aug 10, 2026
@MrMicky-FR

Copy link
Copy Markdown
Owner

Hi, sorry for the delay. I just tested on Spigot 1.8.8 with a 1.8.9 client, and the scoreboard is empty. Do you have any idea what could be the cause? Thank you!

@Dominilk01
Dominilk01 marked this pull request as draft August 22, 2026 07:44
@Dominilk01

Copy link
Copy Markdown
Contributor Author

Il chek it

@Dominilk01

Copy link
Copy Markdown
Contributor Author

Hey i can't reproduce your issue,
Server 1.8.8 + VIA
Client 1.20.4 + 1.8.9
the 1.8.9 client is fine

@MrMicky-FR
MrMicky-FR marked this pull request as ready for review September 21, 2026 06:09
@MrMicky-FR MrMicky-FR added the enhancement New feature or request label Sep 21, 2026
@MrMicky-FR
MrMicky-FR merged commit 872fe56 into MrMicky-FR:master Sep 21, 2026
1 check passed
@MrMicky-FR

Copy link
Copy Markdown
Owner

Great, thanks a lot, the issue was coming from a mistake from me... sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants