Skip to content

Fix Lifted Index calculation in RRFS #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenjaminBlake-NOAA merged 7 commits into from
Oct 26, 2026
Merged

Fix Lifted Index calculation in RRFS #1630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1fc50f8
Fix lifted index calculation in RRFS
Oct 21, 2026
84b0d2c
Merge branch 'develop' into feature/lftx
WenMeng-NOAA Oct 22, 2026
f08b501
Add RT log for WCOSS2
WenMeng-NOAA Oct 22, 2026
09f4658
ursa intel rt log
gspetro-NOAA Oct 23, 2026
b83cb4a
ursa llvm rt log
gspetro-NOAA Oct 23, 2026
67d1580
hercules rt log
gspetro-NOAA Oct 23, 2026
a48a8e7
orion rt log - post bl update
gspetro-NOAA Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sorc/ncep_post.fd/CLDRAD.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
!> field definition).
!> 2026-07-21 | Eric James | Modify MPAS AOD treatment to directly output 2D field from MPASSIT, and add a second
!> | AOD Mie calculation output for MPAS
!> 2026-10-21 | Ben Blake | Fix lifted index (lftx) calculation for RRFS
!>
!> @author Russ Treadon W/NP2 @date 1993-08-30
!---------------------------------------------------------------------------------
Expand Down Expand Up @@ -291,7 +292,7 @@ SUBROUTINE CLDRAD
!
CALL OTLIFT(EGRID1)
!
IF(MODELNAME == 'RAPR') THEN
IF(MODELNAME == 'RAPR' .OR. MODELNAME == 'FV3R') THEN
!$omp parallel do private(i,j)
DO J=JSTA,JEND
DO I=ISTA,IEND
Expand Down
106 changes: 54 additions & 52 deletions tests/logs/rt.log.HERCULES_intel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,66 +1,68 @@
===== Start of UPP Regression Testing Log =====
UPP Hash Tested:
37b464b3143377a54a213b43f47ee611db2d4a9f
f08b50132ced52dbf4680dbc78439821885a8c72

Submodule hashes:
-68953f566b4d728b9ecf9a352c56e2aaeec6d8ec sorc/libIFI.fd
-8fdeb7a816bab893f670e7f592e98713ff613c8e sorc/ncep_post.fd/post_gtg.fd

Run directory: /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1626/ci/rundir/upp-HERCULES
Run directory: /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1630/ci/rundir/upp-HERCULES
Baseline directory: /work/noaa/epic/role-epic/hercules/UPP

Total runtime: 00h:11m:41s
Test Date: 20261021 13:28:38
Total runtime: 00h:31m:26s
Test Date: 20261023 00:03:20
Summary Results:

10/21 18:19:15Z -aigfs test: your new post executable generates bit-identical aigfs.t18z.pres.f084.grib2 as the develop branch
10/21 18:19:15Z -aigfs test: your new post executable generates bit-identical aigfs.t18z.sfc.f084.grib2 as the develop branch
10/21 18:19:16Z -aqm test: your new post executable generates bit-identical CMAQ08.tm00 as the develop branch
10/21 18:19:23Z -gefsv12 test: your new post executable generates bit-identical geaer.t00z.master.grb2f060 as the develop branch
10/21 18:19:24Z -sfs test: your new post executable generates bit-identical sfs.t00z.master.grb2f060 as the develop branch
10/21 18:19:43Z -hafs test: your new post executable generates bit-identical HURPRS42.tm00 as the develop branch
10/21 18:19:50Z -gefsv13 test: your new post executable generates bit-identical gefs.t00z.master.grb2f009 as the develop branch
10/21 18:19:51Z -mpas test: your new post executable generates bit-identical POSTNAT06.tm00 as the develop branch
10/21 18:19:52Z -mpas test: your new post executable generates bit-identical POSTPRS06.tm00 as the develop branch
10/21 18:19:52Z -mpas test: your new post executable generates bit-identical POSTTWO06.tm00 as the develop branch
10/21 18:19:54Z -3drtma test: your new post executable generates bit-identical WRFNAT.GrbF00 as the develop branch
10/21 18:19:55Z -3drtma test: your new post executable generates bit-identical WRFTWO.GrbF00 as the develop branch
10/21 18:19:55Z -3drtma test: your new post executable generates bit-identical WRFPRS.GrbF00 as the develop branch
10/21 18:20:01Z -rap test: your new post executable generates bit-identical WRFPRS.GrbF06 as the develop branch
10/21 18:20:01Z -rap test: your new post executable generates bit-identical WRFNAT.GrbF06 as the develop branch
10/21 18:20:15Z -nmmb test: your new post executable generates bit-identical BGDAWP03.tm00.Grib2 as the develop branch
10/21 18:20:16Z -nmmb test: your new post executable generates bit-identical BGRD3D03.tm00.Grib2 as the develop branch
10/21 18:20:16Z -nmmb test: your new post executable generates bit-identical BGRDSF03.tm00.Grib2 as the develop branch
10/21 18:20:57Z -mpas_hfip test: your new post executable generates bit-identical NATLEV.GrbF48 as the develop branch
10/21 18:20:58Z -mpas_hfip test: your new post executable generates bit-identical PRSLEV.GrbF48 as the develop branch
10/21 18:20:59Z -mpas_hfip test: your new post executable generates bit-identical 2DFLD.GrbF48 as the develop branch
10/21 18:20:59Z -hrrr test: your new post executable generates bit-identical WRFTWO.GrbF10 as the develop branch
10/21 18:20:59Z -hrrr test: your new post executable generates bit-identical WRFPRS.GrbF10 as the develop branch
10/21 18:21:00Z -hrrr test: your new post executable generates bit-identical WRFNAT.GrbF10 as the develop branch
10/21 18:21:38Z -gcafs test: your new post executable generates bit-identical GFSPRS.GrbF60 as the develop branch
10/21 18:21:38Z -gcafs test: your new post executable generates bit-identical GFSFLX.GrbF60 as the develop branch
10/21 18:28:04Z -rrfs test: your new post executable generates bit-identical PRSLEV36.tm00 as the develop branch
10/21 18:28:29Z -rrfs test: your new post executable generates bit-identical NATLEV36.tm00 as the develop branch
10/21 18:28:30Z -gfs test: your new post executable generates bit-identical gfs.t00z.master.f012.grib2 as the develop branch
10/21 18:28:32Z -rrfs test: your new post executable generates bit-identical 2DFLD36.tm00 as the develop branch
10/21 18:28:32Z -gfs test: your new post executable generates bit-identical gfs.t00z.sflux.f012.grib2 as the develop branch
10/21 18:28:32Z -gfs test: your new post executable generates bit-identical gfs.t00z.master-goes.f012.grib2 as the develop branch
10/21 18:19:37Z -Runtime: sfs_test 00:00:16 -- baseline 00:01:20
10/21 18:19:37Z -Runtime: aqm_test 00:00:08 -- baseline 00:00:30
10/21 18:19:37Z -Runtime: aigfs_test 00:00:07 -- baseline 00:00:30
10/21 18:19:37Z -Runtime: gefsv12_test 00:00:15 -- baseline 00:01:00
10/21 18:19:52Z -Runtime: gefsv13_test 00:00:42 -- baseline 00:02:00
10/21 18:20:23Z -Runtime: nmmb_test 00:01:08 -- baseline 00:03:00
10/21 18:20:23Z -Runtime: rap_test 00:00:54 -- baseline 00:02:00
10/21 18:21:08Z -Runtime: hrrr_test 00:01:52 -- baseline 00:06:00
10/21 18:21:08Z -Runtime: hafs_test 00:00:35 -- baseline 00:01:00
10/21 18:21:08Z -Runtime: 3drtma_test 00:00:47 -- baseline 00:03:00
10/21 18:21:08Z -Runtime: mpas_test 00:00:44 -- baseline 00:02:30
10/21 18:21:08Z -Runtime: mpas_hfip_test 00:01:52 -- baseline 00:05:00
10/21 18:21:53Z -Runtime: gcafs_test 00:02:30 -- baseline 00:02:30
10/21 18:28:38Z -Runtime: rrfs_test 00:09:24 -- baseline 00:12:00
10/21 18:28:38Z -Runtime: gfs_test 00:09:24 -- baseline 00:25:00
10/23 04:34:12Z -aigfs test: your new post executable generates bit-identical aigfs.t18z.pres.f084.grib2 as the develop branch
10/23 04:34:12Z -aigfs test: your new post executable generates bit-identical aigfs.t18z.sfc.f084.grib2 as the develop branch
10/23 04:34:14Z -aqm test: your new post executable generates bit-identical CMAQ08.tm00 as the develop branch
10/23 04:34:21Z -gefsv12 test: your new post executable generates bit-identical geaer.t00z.master.grb2f060 as the develop branch
10/23 04:34:22Z -sfs test: your new post executable generates bit-identical sfs.t00z.master.grb2f060 as the develop branch
10/23 04:34:44Z -hafs test: your new post executable generates bit-identical HURPRS42.tm00 as the develop branch
10/23 04:34:48Z -gefsv13 test: your new post executable generates bit-identical gefs.t00z.master.grb2f009 as the develop branch
10/23 04:34:49Z -mpas test: your new post executable generates bit-identical POSTNAT06.tm00 as the develop branch
10/23 04:34:50Z -mpas test: your new post executable generates bit-identical POSTPRS06.tm00 as the develop branch
10/23 04:34:51Z -mpas test: your new post executable generates bit-identical POSTTWO06.tm00 as the develop branch
10/23 04:34:52Z -3drtma test: your new post executable generates bit-identical WRFNAT.GrbF00 as the develop branch
10/23 04:34:53Z -3drtma test: your new post executable generates bit-identical WRFTWO.GrbF00 as the develop branch
10/23 04:34:53Z -3drtma test: your new post executable generates bit-identical WRFPRS.GrbF00 as the develop branch
10/23 04:35:03Z -rap test: your new post executable generates bit-identical WRFPRS.GrbF06 as the develop branch
10/23 04:35:04Z -rap test: your new post executable generates bit-identical WRFNAT.GrbF06 as the develop branch
10/23 04:35:15Z -nmmb test: your new post executable generates bit-identical BGDAWP03.tm00.Grib2 as the develop branch
10/23 04:35:15Z -nmmb test: your new post executable generates bit-identical BGRD3D03.tm00.Grib2 as the develop branch
10/23 04:35:16Z -nmmb test: your new post executable generates bit-identical BGRDSF03.tm00.Grib2 as the develop branch
10/23 04:35:52Z -mpas_hfip test: your new post executable generates bit-identical NATLEV.GrbF48 as the develop branch
10/23 04:35:54Z -mpas_hfip test: your new post executable generates bit-identical PRSLEV.GrbF48 as the develop branch
10/23 04:35:55Z -hrrr test: your new post executable generates bit-identical WRFTWO.GrbF10 as the develop branch
10/23 04:35:55Z -mpas_hfip test: your new post executable generates bit-identical 2DFLD.GrbF48 as the develop branch
10/23 04:35:55Z -hrrr test: your new post executable generates bit-identical WRFPRS.GrbF10 as the develop branch
10/23 04:35:56Z -hrrr test: your new post executable generates bit-identical WRFNAT.GrbF10 as the develop branch
10/23 04:36:40Z -gcafs test: your new post executable generates bit-identical GFSPRS.GrbF60 as the develop branch
10/23 04:36:41Z -gcafs test: your new post executable generates bit-identical GFSFLX.GrbF60 as the develop branch
10/23 04:43:08Z -rrfs test: your new post executable generates bit-identical PRSLEV36.tm00 as the develop branch
10/23 04:43:16Z -gfs test: your new post executable generates bit-identical gfs.t00z.master.f012.grib2 as the develop branch
10/23 04:43:18Z -gfs test: your new post executable generates bit-identical gfs.t00z.sflux.f012.grib2 as the develop branch
10/23 04:43:18Z -gfs test: your new post executable generates bit-identical gfs.t00z.master-goes.f012.grib2 as the develop branch
10/23 05:00:02Z -rrfs test: your new post executable did not generate bit-identical NATLEV36.tm00 as the develop branch
10/23 05:03:06Z -rrfs test: your new post executable did not generate bit-identical 2DFLD36.tm00 as the develop branch
10/23 04:34:32Z -Runtime: sfs_test 00:00:17 -- baseline 00:01:20
10/23 04:34:32Z -Runtime: aqm_test 00:00:09 -- baseline 00:00:30
10/23 04:34:32Z -Runtime: aigfs_test 00:00:07 -- baseline 00:00:30
10/23 04:34:32Z -Runtime: gefsv12_test 00:00:16 -- baseline 00:01:00
10/23 04:35:02Z -Runtime: gefsv13_test 00:00:43 -- baseline 00:02:00
10/23 04:35:18Z -Runtime: nmmb_test 00:01:11 -- baseline 00:03:00
10/23 04:35:18Z -Runtime: rap_test 00:00:59 -- baseline 00:02:00
10/23 04:36:03Z -Runtime: hrrr_test 00:01:51 -- baseline 00:06:00
10/23 04:36:03Z -Runtime: hafs_test 00:00:39 -- baseline 00:01:00
10/23 04:36:03Z -Runtime: 3drtma_test 00:00:48 -- baseline 00:03:00
10/23 04:36:03Z -Runtime: mpas_test 00:00:46 -- baseline 00:02:30
10/23 04:36:03Z -Runtime: mpas_hfip_test 00:01:51 -- baseline 00:05:00
10/23 04:36:48Z -Runtime: gcafs_test 00:02:36 -- baseline 00:02:30
10/23 05:03:19Z -Runtime: rrfs_test 00:29:01 -- baseline 00:12:00
10/23 05:03:20Z -Runtime: gfs_test 00:09:14 -- baseline 00:25:00
Check tests:
['sfs', 'aqm', 'aigfs', 'gefsv12', 'gefsv13', 'nmmb', 'rap', 'hrrr', 'hafs', '3drtma', 'mpas', 'mpas_hfip', 'gcafs', 'rrfs', 'gfs']
No changes in test results detected.
There are changes in results for case rrfs in /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1630/ci/rundir/upp-HERCULES/rrfs_2026032512/NATLEV36.tm00
There are changes in results for case rrfs in /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1630/ci/rundir/upp-HERCULES/rrfs_2026032512/2DFLD36.tm00
Refer to .diff files in rundir: /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1630/ci/rundir/upp-HERCULES for details on differences in results for each case.
===== End of UPP Regression Testing Log =====
Loading
Loading