Repository navigation
determine the archive cycledef more intelligently and update the default RETRO_PERIOD - #1749
Merged
Merged
Conversation
guoqing-noaa
commented
Sep 29, 2026
guoqing-noaa
commented
Contributor
- determine the archive cycledef more intelligently
- set the default RETRO_PERIOD to start at 2024050600 to be more aligned with the RRFSv2 retros we have been running.
…OAA-EMC#1743) * add tools/get_superyamls.sh to facilite getting superyamls from individual observers * update to use hifiyaml v0.2.2 and yamltools4jedi v0.2.3 * update tests/generate_xml_files.sh * use error0 and error1 for satrad yaml files * remove trailing empty spaces * remove polyogn filters from all observers if JEDI_POLYGON_FILTER=false * fine tuning * use unique filter.identifier.name in abi_g16.yaml and abi_g18.yaml * use unique filter.identifier.name in atms and cris yaml files * further address YAML convention linting comments * more changes from linting * add rrfs yaml convention linting * need to yamllint parm/observers/*.yaml * address linting comments on linter_rrfs_yaml_convention.py * add yamllint comments * ignore undeclared 'polygonConfig' in individual observer yaml files * pass the linting for linter_rrfs_yaml_convention.py * intentionally violate YAML convention * revert the violation change * update yamltools to v0.2.4 * ignore XML output differences * fix the runtime linters.yaml ---------
guoqing-noaa
requested review from
BenjaminBlake-NOAA,
MatthewPyle-NOAA and
ShunLiu-NOAA
as code owners
September 29, 2026 03:21
guoqing-noaa
requested review from
HaidaoLin-NOAA,
Junjun-NOAA,
chunhuazhou and
spanNOAA
September 29, 2026 03:22
* Addition of TMS S02 observation space YAML * Remove Create Diagnostic fiters section and comment Remove Clear-sky TB checks Combine Q2/Q4 filters into one filter for all channels Move PreQC to obs pre filter section Add channel-specific gross check check identifiers Change Thinning to Gaussian Thinning for identifier name Refine/shorten clear-sky and all-sky error assignment filters * Added conditional Clear-Sky Tb check for all channels * Change actions blocks and reorder PreQC and Thinning filters * Change Variable Assignment to Perform Action * Updated TMS S02 YAML * Address linter comments ---------
MatthewPyle-NOAA
approved these changes
Sep 29, 2026
MatthewPyle-NOAA
force-pushed
the
rrfs-mpas-jedi
branch
3 times, most recently
from
September 29, 2026 16:29
7e6274f to
1b37357
Compare
Junjun-NOAA
approved these changes
Sep 29, 2026
spanNOAA
approved these changes
Sep 29, 2026
HaidaoLin-NOAA
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.