Range check mask_table entries before writing maskmap

[arpitjain099]

parse_mask_table_2d checks quite a lot before it uses the file: nmask against the record count, the layout against size(maskmap), ntiles, npes. Then it writes at whatever indices the records carried:

call mpp_broadcast(mask_list, 2*nmask, mpp_root_pe())
do n = 1, nmask
   maskmap(mask_list(n,1),mask_list(n,2)) = .false.
enddo

Running that loop with the shapes a 2 by 3 layout gives, and an entry of 9,9:

with -fcheck=bounds : Fortran runtime error: Index '9' of dimension 2 of array 'maskmap' above upper bound of 3
without             : runs to completion, maskmap unchanged, exit 0

The second line is the one that matters: production builds do not carry -fcheck, so a mask table with a typo writes a .false. somewhere outside the array and the run continues.

The check compares each index against size(maskmap, ...) and raises the same mpp_error(FATAL, ...) the routine already uses for the other malformed cases. parse_mask_table_3d has the same loop and gets the same treatment.

I could not build FMS here, it needs MPI and netCDF, so the runs above are that loop with the same array shapes rather than the library.