Skip to content

ci: skip workflows whose inputs did not change - #1397

Merged
roivanov merged 1 commit into
NVIDIA:mainfrom
roivanov:ci/split-workflow-changes
Oct 8, 2026
Merged

roivanov merged 1 commit into
NVIDIA:mainfrom
roivanov:ci/split-workflow-changes

Conversation

@roivanov

@roivanov roivanov commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Skip Tile, CodeQL, and the naming guard when a change cannot affect what those jobs read.

Changes

  • Declare the Tile any_changed filter so a non-Tile diff skips the Tile jobs, while a push with no detectable diff still runs them. The job condition already read any_changed, but dorny/paths-filter only sets an output for a filter that is declared. That name was not declared, so the output stayed empty. Empty is not 'true', and the condition was any_changed != 'true', so it was always true and every Tile job ran on every push.
  • Run CodeQL on push and pull request only when Rust, Cargo manifests, .github/, shell, or Python files change. The weekly schedule still scans the whole tree.
  • Run the naming guard only for cuda-oxide/crates/, its script, and its workflow. The comment records why cutile-rs and the shared host crates stay out: the script's SEARCH_ROOTS does not read them.

Testing

Workflow configuration only. No crate, example, or guard behavior changed, so just check and cargo oxide run were not run.

  • just -f cuda-oxide/Justfile check passes (the local mirror of CI: fmt, clippy, tests, guards, docs)
  • cargo oxide run <example> passes, or cuda-oxide/scripts/smoketest.sh -o '^<example>$'
  • New example added (if applicable)

Checklist

  • All commits signed off (git commit -s)
  • SPDX headers on new source files

Questions about the review? Ping us in #contributors on Discord.

Tile jobs ran on every push because any_changed was never declared.
CodeQL and the naming guard now run only when the files they read change.

Signed-off-by: Roman Ivanov <rivanov@nvidia.com>
@roivanov
roivanov force-pushed the ci/split-workflow-changes branch from fbeaa86 to 5a55011 Compare October 7, 2026 23:06
@roivanov roivanov changed the title ci: path filters and let main checks finish ci: skip workflows whose inputs did not change Oct 7, 2026

@elibol elibol left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roivanov
roivanov merged commit a51ef44 into NVIDIA:main Oct 8, 2026
60 checks passed
@roivanov
roivanov deleted the ci/split-workflow-changes branch October 8, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants