This repository was archived by the owner on Mar 3, 2026. It is now read-only.
Repository navigation
ngpu/glcontext: enable sRGB framebuffer conversions - #315
Merged
Merged
Conversation
mbouron
force-pushed
the
srgb
branch
2 times, most recently
from
July 15, 2025 13:34
52e1d14 to
c19cc96
Compare
mbouron
changed the title
mbouron
force-pushed
the
srgb
branch
6 times, most recently
from
July 21, 2025 11:56
4c86006 to
9c83a82
Compare
mbouron
changed the title
ubitux
approved these changes
Nov 10, 2025
ubitux
left a comment
ubitux
left a comment
Contributor
There was a problem hiding this comment.
Probably OK, tho with srgb=False the test fails with only 2% error. This is probably because the fingerprint works on local differentiation; a color picker would probably be more reliable if you're comparing sRGB vs linear colors.
Adds more sRGB formats for internal use.
sRGB framebuffer conversions are automatically enabled on OpenGLES.
Swapchain framebuffer colorspace is left to the default (linear) and is not configurable yet.
Swapchain framebuffer colorspace is left to the default (linear) and is not configurable yet.
mbouron
force-pushed
the
srgb
branch
3 times, most recently
from
November 10, 2025 19:54
1944b6f to
799c049
Compare
Contributor
Author
I agree. I did that because of laziness. I changed the test. |
Ensures linear->sRGB conversions are performed when using sRGB color formats. This test targets the OpenGL backend which needs to explicitly enable GL_FRAMEBUFFER_SRGB to behave like Vulkan and OpenGLES.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.