Conversation
OCA-git-bot
added
series:18.0
mod:helpdesk_mgmt_fieldservice
SirPyTech
force-pushed
the
18.0-helpdesk-wizard-security
branch
from
August 25, 2026 08:09
4ee59f2 to
2463372
Compare
This commit reviews the security rules around the fsm_order_close_wizard. The "Complete" button on the fsm.order triggered an access error for fieldservice.group_fsm_user_own. The commit allows fieldservice.group_fsm_user_own to use the wizard as well. However, the wizard is now only shown if the user also has write permission on the specific ticket (so as to play nice with a variety of setups, including helpdesk_mgmt.group_helpdesk_user_own). If the user has permission to write on the ticket, the wizard will be shown as before; otherwise it will simply be skipped, but the fsm.order will be closed as it should. There's also some code cleanup on the wizard, such as removing the unused team_id field. Co-authored-by: Simone Rubino <simone.rubino@pytech.it>
SirPyTech
force-pushed
the
18.0-helpdesk-wizard-security
branch
from
August 25, 2026 08:29
2463372 to
a1b5267
Compare
HekkiMelody
approved these changes
Aug 25, 2026
HekkiMelody
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposing again a fix that was already proposed for
14.0in #593 and #404, and for16.0in #921 (including a test 🚀) hoping the 4th time's the charm 🍀This commit reviews the security rules around the fsm_order_close_wizard.
The "Complete" button on the fsm.order triggered an access error for fieldservice.group_fsm_user_own. The commit allows fieldservice.group_fsm_user_own to use the wizard as well. However, the wizard is now only shown if the user also has write permission on the specific ticket (so as to play nice with a variety of setups, including helpdesk_mgmt.group_helpdesk_user_own).
If the user has permission to write on the ticket, the wizard will be shown as before; otherwise it will simply be skipped, but the fsm.order will be closed as it should.
There's also some code cleanup on the wizard, such as removing the unused team_id field.