Repository navigation
remove: drop unused /assess/mappingRDF endpoint and RML mapping (issu… - #33
Merged
andresTabiTuwien merged 2 commits intoAug 27, 2026
Merged
Conversation
…#22) The maDMP-to-RDF mapping feature (ToRDFService, the /assess/mappingRDF endpoint, and the RML mapping resources it depended on) has no current consumers. Rather than carry the residual filesystem complexity a proper fix still couldn't fully eliminate (see the parked AT/issue-22-rml-fix-wip branch), remove it from main for now.
… commit The earlier removal commit (2c41465) only captured the file deletions (ToRDFService.kt, the RML mapping resources, etc.) — a bad pathspec in the git add command silently caused pom.xml, EvaluationController.kt, and EvaluationManagerService.kt to never get staged, so the endpoint removal and the ToRDFService import/dependency cleanup in those three files never made it into that commit. This is what CI caught: "Unresolved reference: ToRDFService" in EvaluationManagerService.kt, since the class it imported no longer exists. This commit adds the missing pieces: removes the /mappingRDF endpoint from EvaluationController, removes mapToRDF() and the toRDFService dependency from EvaluationManagerService, and drops the now-unused rmlmapper/rdf4j/idlab-functions-java dependencies from pom.xml. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
andresTabiTuwien
deleted the
AT/issue-22-avoid-unnecessary-use-of-file-system
branch
August 28, 2026 08:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e #22)
The maDMP-to-RDF mapping feature (ToRDFService, the /assess/mappingRDF endpoint, and the RML mapping resources it depended on) has no current consumers. Rather than carry the residual filesystem complexity a proper fix still couldn't fully eliminate (see the parked AT/issue-22-rml-fix-wip branch), remove it from main for now.
Summary
Removes the
/assess/mappingRDFendpoint (maDMP-to-RDF mapping viaToRDFService) and its RML mapping resources, since the feature currently has no consumers. This closes issue #22 by eliminating the risky filesystem usage entirely ratherthan carrying a partial fix for a feature nobody uses — a working fix is preserved on a separate branch in case the endpoint comes back later.
Related Issue
Closes #22
Changes
runMapping(POST /assess/mappingRDF) fromEvaluationControllermapToRDF()fromEvaluationManagerService, along wit