Repository navigation
Fix/cost entity result - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two evaluator functions that could report wrong results and removes placeholder evaluator functions that returned fixed PASS/FAIL results without checking anything.
costEntityValuesPresentcould return PASS for a DMP with incomplete cost entries, because the last entry overwrote the result.contributorValuesPresent(test "Roles in RDM Defined", metric role.co.1) only checked that the contributor list was not empty and never looked at roles.Related Issue
Changes
costEntityValuesPresent(DCSCompletenessEvaluator): every cost entry is checked and logged; the test returns PASS only if all entries have title, description, value and currency_code. Empty cost lists and entries that are not JSONobjects return FAIL.
contributorValuesPresent(DCSCompletenessEvaluator): each contributor must have at least one non-blank role (DCS 1.2rolefield). The test returns FAIL if there are no contributors, or if any contributor has no role, an emptylist, a
rolethat isn't a list, or a blank entry. Each failing contributor is listed inaffectedElementsandguidance. The function name is unchanged, so the deployed test68bf0fdbd66a3009c09e6825keeps working.CompletenessEvaluator.testFuntion(always FAIL), andevaluateCoherentLicenseinComplianceEvaluatorand inFeasibilityEvaluator(always PASS). No seeded or deployed test references them;