Skip to content

Fix/cost entity result - #38

Merged
andresTabiTuwien merged 3 commits into
mainfrom
fix/cost-entity-result
Oct 7, 2026
Merged

andresTabiTuwien merged 3 commits into
mainfrom
fix/cost-entity-result

Conversation

@andresTabiTuwien

Copy link
Copy Markdown
Collaborator

Summary

Fixes two evaluator functions that could report wrong results and removes placeholder evaluator functions that returned fixed PASS/FAIL results without checking anything.

  • costEntityValuesPresent could return PASS for a DMP with incomplete cost entries, because the last entry overwrote the result.
  • contributorValuesPresent (test "Roles in RDM Defined", metric role.co.1) only checked that the contributor list was not empty and never looked at roles.
  • Three placeholder functions returned hard-coded results and could make an evaluation look like it passed or failed when nothing was checked.

Related Issue

Changes

  • costEntityValuesPresent (DCSCompletenessEvaluator): every cost entry is checked and logged; the test returns PASS only if all entries have title, description, value and currency_code. Empty cost lists and entries that are not JSON
    objects return FAIL.
  • contributorValuesPresent (DCSCompletenessEvaluator): each contributor must have at least one non-blank role (DCS 1.2 role field). The test returns FAIL if there are no contributors, or if any contributor has no role, an empty
    list, a role that isn't a list, or a blank entry. Each failing contributor is listed in affectedElements and guidance. The function name is unchanged, so the deployed test 68bf0fdbd66a3009c09e6825 keeps working.
  • Removed placeholders: CompletenessEvaluator.testFuntion (always FAIL), and evaluateCoherentLicense in ComplianceEvaluator and in FeasibilityEvaluator (always PASS). No seeded or deployed test references them;

@andresTabiTuwien
andresTabiTuwien merged commit cc9e674 into main Oct 7, 2026
1 check passed
@andresTabiTuwien
andresTabiTuwien deleted the fix/cost-entity-result branch October 26, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant