Repository navigation
Add coverage tests for the remaining pilot metrics - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the 23 pilot metric tests that were still missing from
DCSCoverageEvaluator, so all 43 OSTrails pilot metrics with a coverage test are now implemented. They are also registered in the database throughCoverageMetricSeeder. Rules follow the OSTrails DMP evaluation metrics catalog (https://docs.ostrails.eu/en/latest/commons/dmp/dmp-evaluation-metrics.html). Where the catalog conflicts with the DMP Common Standard (DCS), the change is listed below.Changes
New tests
Each test is one function, registered in
DCSCoverageEvaluator.functionMapthrough its area file. The comment above each function states when it returns PASS, FAIL or INDETERMINATE.New and reused datasets (
DatasetProvenanceTests.kt)data.new.1New dataset declareddata.new.2Collection or creation method (technical_resource)data.new.3Access conditions (data_accessand license)data.new.4Sufficient metadatadata.reused.co.2Persistent identifierdata.reused.co.3License withstart_datedata.reused.co.4Distribution informationdata.reused.co.6Personal data flagdata.reused.co.7Sensitive data flagdata.reused.co.8Access URLSecurity, sensitive data and access (
SecurityAccessTests.kt)secur.co.2Access rights management for sensitive datasecur.comp.1GDPR or ethics review referencedsecur.co.4Access control and user rolessens.secure.co.1Protection method describeddata.shar.co.2Data restrictionsdata.shar.comp.2Embargoown.co.2Data owner roleRepository, storage and cost (
RepositoryStorageTests.kt)repo.comp.2FAIR-conformant repositorystore.cov.2Secure storage in a trusted repositoryrepo.co.4Backup strategymeta.qual.2README referencedcost.co.1Personnel and monetary budgetcost.co.2No additional resources stated