Repository navigation
Add back free-surface normal computation based on finite differencing - #3503
Merged
andrew-platt merged 1 commit intoNov 3, 2026
Merged
andrew-platt merged 1 commit into
andrew-platt merged 1 commit into
Conversation
The free-surface normal used by the Morison hydrostatic loads is again computed by central differencing the wave elevation over +/- the section half-width, now on the cubic-interpolated surface. The exact point gradient let waves shorter than the member section tilt the waterplane, exciting high-frequency (tower-mode) response on surface-piercing columns (see OpenFAST#3496). The point gradient is kept when no half-width is given (e.g., SeaState C binding). Also apply WaveTimeShift consistently in WaveField_GetNodeTotalWaveElev and the vertical-stretching branches of WaveField_GetNodeWaveVel and WaveField_GetNodeWaveVelAcc, check the GridInterpSetupN error status, and return a vertical normal when no wave elevation data exists. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
luwang00
added
Module: HydroDyn
Module: SeaState
luwang00
marked this pull request as ready for review
November 2, 2026 18:47
andrew-platt
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready for merging.
Feature or improvement description
The free-surface normal used by the Morison hydrostatic loads is again computed by central differencing the wave elevation over +/- the section half-width, now on the cubic-interpolated surface. The exact point gradient let waves shorter than the member section tilt the waterplane, exciting high-frequency response on surface-piercing columns (see #3496). The point gradient is kept when no half-width is given (e.g., SeaState C binding).
Also apply
WaveTimeShiftconsistently inWaveField_GetNodeTotalWaveElevand the vertical-stretching branches ofWaveField_GetNodeWaveVelandWaveField_GetNodeWaveVelAcc, check theGridInterpSetupNerror status, and return a vertical normal when no wave elevation data exists.Related issue, if one exists
Addressed issue #3496. Close issue upon merging.
Additional Information
The changes made in this PR will create merge conflicts with
devthat will need to be resolved.Impacted areas of the software
SeaState, HydroDyn
Generative AI usage
Co-authored-by: Anthropic Claude claude@anthropic.com
Assisted by: GitHub Copilot support@github.com
Test results, if applicable
All tests passed as is; r-test merging is not required.