Repository navigation
Dev - #3
Open
josephjclark wants to merge 1 commit into
Open
Dev#3josephjclark wants to merge 1 commit into
josephjclark wants to merge 1 commit into
Conversation
josephjclark
commented
Oct 7, 2026
josephjclark
commented
Oct 7, 2026
| updated_at: 2026-09-21T14:01:20Z | ||
| lock_version: 40 | ||
| updated_at: 2026-10-02T16:51:00Z | ||
| lock_version: 41 |
Contributor
Author
There was a problem hiding this comment.
This change is just (correctly) telling us that the app version was updated between the branches. This is just how it is.
josephjclark
commented
Oct 7, 2026
| - id: webhook | ||
| type: webhook | ||
| webhook_reply: after_completion | ||
| webhook_reply: before_start |
Contributor
Author
There was a problem hiding this comment.
This diff worries me because I didn't make this change. An issue is tracked on linear
josephjclark
commented
Oct 7, 2026
| name: joe | ||
| destination_url: https://www.joe.test.com/12345 | ||
| enabled: true | ||
| channels: {} |
Contributor
Author
There was a problem hiding this comment.
I've opened this as OpenFn/lightning#5231
We'll have to address it seperately. Right now this blocks me from merging the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shows the updated v2 project structure targed against a fork of main (where the original project has been checked out in the updated format too).
So the idea here is to show the diff between a sandbox and the main project after the changes of OpenFn/kit#1567