Repository navigation
Remove trigger.enabled - #1564
Merged
Merged
Conversation
josephjclark
added a commit
that referenced
this pull request
Oct 5, 2026
* Remove trigger.enabled (#1564) * lexicon: remove trigger.enabled from spec * update handling of trigger.enabled * update version hash * changeset * remove log * update version util and fix tests * add notes to docs * remove .only * fix test * update test * fix integration test * Support channels in v2 sync (#1566) * project: read and write channels via channels.yaml * project: fix sandbox merge dropping channels and keep remote channel ids on merge * cli: deploy channel changes and deletions, and clear stale channels.yaml on checkout * project: track removed channels on merge and send them as deletes Move channel delete detection out of the CLI deploy handler and into the project's merge step, so any caller of toAppState sends removed channels to Lightning as deletes. * project: store channels under a channels key in resources.yaml instead of channels.yaml * project: key resources.yaml channels by id with a required name * project: match channels by their resources.yaml id so renames keep the channel * Resource Diffs (#1572) * restructure project-diff * diff channels in project * log resource diff in CLI * changeset * one more changeset for the road * format * simplify --------- Co-authored-by: Joe Clark <joe@openfn.org> * No checkout after deploy (#1573) * don't checkout after deploy * test * changeset * fix test * version --------- Co-authored-by: Midigo Frank <39288959+midigofrank@users.noreply.github.com>
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
This PR removes trigger.enabled from spec representations in sync v2: so when you pull a project, the trigger's enabled state is no longer present in workflow.yaml.
This prevents nonsense diffs when using sandboxes with gitub.
It requires a matching PR in lightning to remove
trigger.enabledfrom the version hash (step.enabled is fine). That'll come later.Fixes https://linear.app/openfn/issue/OFN-4700/dont-disable-triggers-on-sandboxes
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy