Make KiNET output socket non-blocking - #2070
Open
iibaranov-IG wants to merge 1 commit into
Open
iibaranov-IG wants to merge 1 commit into
iibaranov-IG wants to merge 1 commit into
Conversation
An unreachable destination can otherwise block the shared OLA event loop while the network stack resolves it, delaying every healthy universe. Configure the KiNET descriptor before binding and verify the real socket flag in the node test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a KiNET target disappears, a blocking UDP send can hold OLA's shared event loop while the kernel resolves the unreachable neighbour. That delays unrelated healthy universes and explains the stutter followed by catch-up bursts reported in #1850.
Set the KiNET socket descriptor non-blocking during initialization. If the socket cannot be configured, startup fails explicitly; if a later send cannot proceed, the existing send-failure path drops that frame instead of blocking other outputs.
Validation:
plugins/kinet/KiNetTester: all 3 tests pass, including a new check of the actual descriptor'sO_NONBLOCKflagFixes #1850