Repository navigation
Conversation
|
I had some ideas on how to use the check on the original issue (#1289) - it is kind of similar to your idea but a little different |
|
Here is a little migration guide I made that might help catch some more variables. I closed my PR since it is stale, and your solution is a better approach. |
…nto Variable_deprecation
…nto Variable_deprecation
Kenneth-T-Moore
left a comment
Kenneth-T-Moore
left a comment
There was a problem hiding this comment.
This looks ready once the deprecated variable dictionary is moved into its own file in aviary/interface.
| 'dynamic:vehicle:Propulsion.fuel_flow_rate,': ( | ||
| 'dynamic:vehicle:Propulsion.fuel_flow_rate', | ||
| '1171', | ||
| '1.0.0', | ||
| '6/15/2026', | ||
| ), | ||
| 'dynamic:vehicle:Propulsion.fuel_flow_rate_negative': ( | ||
| 'dynamic:vehicle:Propulsion.fuel_flow_rate_negative', | ||
| '1171', | ||
| '1.0.0', | ||
| '6/15/2026', | ||
| ), | ||
| 'dynamic:vehicle:Propulsion.fuel_flow_rate_negative_total': ( | ||
| 'dynamic:vehicle:Propulsion.fuel_flow_rate_negative_total', | ||
| '1171', | ||
| '1.0.0', | ||
| '6/15/2026', | ||
| ), | ||
| 'dynamic:vehicle:Propulsion.fuel_flow_rate_total': ( | ||
| 'dynamic:vehicle:Propulsion.fuel_flow_rate_total', | ||
| '1223', | ||
| '1.0.0', | ||
| '8/19/2026', | ||
| ), |
There was a problem hiding this comment.
"P" in propulsion incorrectly capitalized, changed variable names don't have "mass" in them (they are copies of original name)
There was a problem hiding this comment.
And periods instead of colons
There was a problem hiding this comment.
I changed "Propulsion." to "propulsion:" now.
There was a problem hiding this comment.
FUEL_MASS_FLOW_RATE = 'fuel_flow_rate'
FUEL_MASS_FLOW_RATE_NEGATIVE = 'fuel_flow_rate_negative'
FUEL_MASS_FLOW_RATE_NEGATIVE_TOTAL = 'fuel_flow_rate_negative_total'
FUEL_MASS_FLOW_RATE_TOTAL = 'fuel_flow_rate_total'
Should we change them to:
FUEL_MASS_FLOW_RATE = 'fuel_mass_flow_rate'
FUEL_MASS_FLOW_RATE_NEGATIVE = 'fuel_mass_flow_rate_negative'
FUEL_MASS_FLOW_RATE_NEGATIVE_TOTAL = 'fuel_mass_flow_rate_negative_total'
FUEL_MASS_FLOW_RATE_TOTAL = 'fuel_mass_flow_rate_total'
?
This branch has not been deployed
3 participants
Summary
This PR targeted Issue #1289.
The warning messages in
parse_inputs()are not printed out because warning is flag to be ignored. This is fixed.Related Issues
Backwards incompatibilities
None
AI Usage
None