[oleibman]

Fix #5032. When evaluating formulas, stop iterating a cell range when the sheet on which the range is located does not exist.

While testing, discovered some commented-out tests in ParseFormulaTest, having nothing to do with this change, that could now be commented back in.

This is:

• a bugfix
• a new feature
• refactoring
• additional unit tests

Checklist:

• Changes are covered by unit tests
  • Changes are covered by existing unit tests
  • New unit tests have been added
• Code style is respected
• Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
• CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
• Documentation is updated as necessary

[dkulyk]

I tried a bounded range with this fix. With 1, 2, 42 in C1:C3 of the sheet that holds the formulas:

Formula	Result
=MAX(Missing!C:C)	#REF!
=MAX(Missing!C1:C5)	42
=SUM(Missing!C1:C3)	45
=IFERROR(MAX(Missing!C1:C5),"oops")	42

So a whole column or row on a missing sheet gives #REF!, and a bounded range on it is evaluated on the formula's own sheet.

[oleibman]

@dkulyk Thank you for the feedback. I will see what I can do.

[oleibman]

@dkulyk Please give the latest push a shot. As the commit message makes clear, I think this works for almost everything, except for COLUMNS and ROWS, which in Excel return the "expected" answer if the reference is to a sheet which doesn't exist. I just can't figure out how to do that in PhpSpreadsheet. I'm willing to take that hit - the function isn't much used, and, since the worksheet is ignored, it should probably be omitted.

[dkulyk]

I checked the bounded ranges from my table. Looks good to me.

On ROWS/COLUMNS: LibreOffice 26.8 makes no exception for them either. In an xlsx it gives #NAME? for every formula with a missing sheet, =ROWS(Missing!B2:K6) included.