Repository navigation
Fix inactive findings displayed when --sync is enabled - #37
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/ParanoiHack/ScopeGuardian/sessions/95738477-7af9-467b-b226-517ed22746d1 Co-authored-by: Nitr4x <10544300+Nitr4x@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with inactive findings being displayed
Fix inactive findings displayed when --sync is enabled
Apr 16, 2026
Nitr4x
approved these changes
Apr 16, 2026
Agent-Logs-Url: https://github.com/ParanoiHack/ScopeGuardian/sessions/d8313a1e-d020-4bc3-89dc-10dab5cfe937 Co-authored-by: Nitr4x <10544300+Nitr4x@users.noreply.github.com>
…ectDojo findings Agent-Logs-Url: https://github.com/ParanoiHack/ScopeGuardian/sessions/ce48654b-55aa-4a8b-b040-81cd476a80b2 Co-authored-by: Nitr4x <10544300+Nitr4x@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ParanoiHack/ScopeGuardian/sessions/ca19a9e0-9c3a-464e-85ba-3595066e7d1a Co-authored-by: Nitr4x <10544300+Nitr4x@users.noreply.github.com>
… Finding model Agent-Logs-Url: https://github.com/ParanoiHack/ScopeGuardian/sessions/b1020961-f935-4809-8eba-7a7d4af4e027 Co-authored-by: Nitr4x <10544300+Nitr4x@users.noreply.github.com>
…red slice Agent-Logs-Url: https://github.com/ParanoiHack/ScopeGuardian/sessions/b1020961-f935-4809-8eba-7a7d4af4e027 Co-authored-by: Nitr4x <10544300+Nitr4x@users.noreply.github.com>
…ine from key Agent-Logs-Url: https://github.com/ParanoiHack/ScopeGuardian/sessions/40b8a34d-e391-4be2-ac5b-ba06d98829e6 Co-authored-by: Nitr4x <10544300+Nitr4x@users.noreply.github.com>
…DD findings Agent-Logs-Url: https://github.com/ParanoiHack/ScopeGuardian/sessions/3502f841-da1e-45f1-ad66-723a0bf01e1c Co-authored-by: Nitr4x <10544300+Nitr4x@users.noreply.github.com>
…titles Agent-Logs-Url: https://github.com/ParanoiHack/ScopeGuardian/sessions/ca115cb4-24f4-4ec7-abc9-337576e0452a Co-authored-by: Nitr4x <10544300+Nitr4x@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ParanoiHack/ScopeGuardian/sessions/b32bee88-67ef-4332-9d55-06221c3012ad Co-authored-by: Nitr4x <10544300+Nitr4x@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ParanoiHack/ScopeGuardian/sessions/ca3d21b4-bad8-484c-9e0d-29ef7cef7cd9 Co-authored-by: Nitr4x <10544300+Nitr4x@users.noreply.github.com>
…Findings to hash-based matching via vulnerability_ids Agent-Logs-Url: https://github.com/ParanoiHack/ScopeGuardian/sessions/1b3b00ae-d8f6-410f-9281-12128e500680 Co-authored-by: Nitr4x <10544300+Nitr4x@users.noreply.github.com>
- Remove vulnId from ComputeFindingHash; hash is now severity|file|line|recommendation - Add UniqueIdFromTool to defectdojo.Finding DTO - enrichOpenGrepResults: inject content hash into extra.fingerprint (DD maps to unique_id_from_tool) instead of check_id into extra.metadata.cve - FilterByActiveFindings: strategy 1 = hash-from-fields (covers Grype/KICS), strategy 2 = UniqueIdFromTool direct match (covers OpenGrep) - Update all tests accordingly Agent-Logs-Url: https://github.com/ParanoiHack/ScopeGuardian/sessions/d13f99a6-362a-4761-b0b3-35a733ebf74a Co-authored-by: Nitr4x <10544300+Nitr4x@users.noreply.github.com>
Nitr4x
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vulnIdfromComputeFindingHashindomains/models/finding.goUniqueIdFromTooltoconnectors/defectdojo/dto.goFinding structopengrep/service.go: inject hash intoextra.fingerprintinenrichOpenGrepResults, update hash call inLoadFindingsgrype/service.go: updateComputeFindingHashcall inLoadFindingskics/service.go: updateComputeFindingHashcall inLoadFindingsfeatures/sync/sync.go: collapseFilterByActiveFindingsto two uniform strategiesfeatures/sync/sync_test.gotestsopengrep/service_test.goenrichment tests (fingerprint injection)