Repository navigation
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了什么
scripts/selftest.mjs：一个自检要在最后一行说出 ok / passed / checked 才算过。Node 在脚本等一个永远不来的结果时以 0 退出，只看退出码会把半路停掉的自检记成通过。extension/download.selftest.js：「点外面关闭」那段还在等一个早已删掉的点击处理（侧边栏输入框和两个弹窗改用原生 field-sizing 与 closedby #471 起由浏览器的closedBy = "any"负责），自检停在那里，后面三段文案检查一直没跑。改成只查closedBy。scripts/smoke.mjs：YouTube 不给可播的视频时（GitHub 机器上常见），跳过侧边栏的种子检查并打印 YouTube 给了什么，和 B站那边的处理一致（冒烟检查：B站不给视频页时跳过种子检查，打印它给了什么 #419）。侧边栏没画出对话时，报错里带上它当时显示的字。验证
download.selftest.js配新的总脚本：报failed: download.selftest.js (it stopped before its last line)。node scripts/selftest.mjs：50 selftests ok。smoke.mjs里把视频号换成不存在的：打印YouTube served no video here (ERROR …)并跳过；正常视频号不跳过。the seeded data drew no .sp-msg-assistant反推的。