Ares DriverKilled Fix

[Fly-Star-him]

What kind of change is this?

• New feature, vanilla bugfix or enhancement of a released feature - changelog, docs and credits entries are needed.
• Improvement to a new (unreleased) feature - docs and credits entries are needed; no changelog entry (Skip Changelog).
• Bugfix to a new (unreleased) feature - credits entry is needed; no changelog or docs entries (Skip Changelog, Skip Docs).
• Bugfix to an old (released) feature - changelog and credits entries are needed; no docs entry (Skip Docs).
• Completely minor change (e.g. a typo fix) - no entries are needed (Skip Changelog, Skip Docs, Skip Credits).

Description

Fixed an issue in Ares where vehicles would occasionally continue to fire and move even after the driver had been killed.

修复Ares下载具驾驶员被击杀后仍有可能继续开火、移动的问题。

[phoboscn-bot]

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户：
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息：

https://www.phoboscn.top/t/topic/798/1

[github-actions]

Nightly build for this pull request:

• compiled-dll-a13321ccd8250ea09e385c18f37ae67353105000.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[TaranDahl]

What is the root cause of this issue

[Fly-Star-him]

This PR needs to be tested for performance.

Some players have reported that vehicles whose drivers have been killed may still launch attacks; here is one such case:

Since I am unable to reproduce this issue myself, I can only implement some potential fixes.

[TaranDahl]

I think your GIF clearly demonstrates the correlation between this issue and the miner being attacked. Combined with the Rescue mission, it most likely points to Base_Is_Attacked.
I suspect the check at 70849D causes the rescue behavior to trigger incorrectly for these units in non-campaign modes.

[NetsuNegi]

I think your GIF clearly demonstrates the correlation between this issue and the miner being attacked. Combined with the Rescue mission, it most likely points to Base_Is_Attacked. I suspect the check at 70849D causes the rescue behavior to trigger incorrectly for these units in non-campaign modes.

Not only in this function, also at 0x7027E9 that called Base_Is_Attacked, this call won't check DriverKilled. This will cause a driver killed vehicle call for reinforcement when receive damage.

[NetsuNegi]

I think your GIF clearly demonstrates the correlation between this issue and the miner being attacked. Combined with the Rescue mission, it most likely points to Base_Is_Attacked. I suspect the check at 70849D causes the rescue behavior to trigger incorrectly for these units in non-campaign modes.

https://www.phoboscn.top/t/topic/800

[Fly-Star-him]

Three new tag statements have been added for custom configuration:

Ares' Abductor Expansion

• When Ares brings a vehicle—whose driver has been killed—into the prison and changes its current country of affiliation, the vehicle, upon being released, will be unable to fire, move, or be recaptured by an engineer. Therefore, two new tags have been added to handle this situation (requires at least Ares 3.0).
  • Abductor.ChangeOwner.ResetDriverKilled allows you to reset the driver's status after capturing a vehicle whose driver has been killed. Determine whether to retain the status of a driver who has been killed based on the MultiplayPassive setting in the country where the capturing player is currently located.
  • Abductor.ChangeOwner.IgnoreDriverKilled prevents the current country of a vehicle whose driver has been killed from being changed; the effect is equivalent to Abductor.ChangeOwner=no.

In rulesmd.ini:

[SOMEWEAPON]                                    ; WeaponType
Abductor.ChangeOwner.ResetDriverKilled=true     ; boolean
Abductor.ChangeOwner.IgnoreDriverKilled=false   ; boolean

Customize whether weapon can target driver-killed vehicles

• In Ares, you cannot skip certain objectives based on whether a unit's driver is dead; this feature has now been added (requires at least Ares 3.0).
  • CanTarget.DriverKilled allows attacks only against units whose drivers have been killed.

In rulesmd.ini:

[SOMEWEAPON]                        ; WeaponType
CanTarget.DriverKilled=false        ; boolean

[Coronia]

it's better to add driverkilled into an enum instead of making a standalone CanTarget.DriverKilled tag. In this case we can expand it with other conditions in the future such as EMP, Berzerk, mind controlled etc

[TaranDahl]

Should do the checking on the flawed mission-changing calls, instead of do that on the general mission process.

[Fly-Star-him]

Should do the checking on the flawed mission-changing calls, instead of do that on the general mission process.

As you mentioned, it currently handles this only in TechnoClass_BeAttacked, TechnoClass_Guard, and UnitClass_EnterIdleMode.

You can review the relevant code again to verify that the changes are correct.

[Fly-Star-him]

Should do the checking on the flawed mission-changing calls, instead of do that on the general mission process.

You can review it again.