Repository navigation
docs: document vBoolean constructor parameters (#1118) - #2032
Conversation
|
Thanks for the pull request, @TheresaYuki! A maintainer will review it shortly. |
|
One or more PR-quality checks did not pass. Review the PR Quality Checks summary in the workflow run for the failed checks and their details, then make any necessary updates. Checklist items may remain unchecked while work is in progress. Please tick each item as you complete it. If you used AI assistance, follow the project's Responsible AI use policy and provide the required disclosures. |
Document vBoolean constructor arguments and distinguish constructor values from TRUE/FALSE parsing via from_ical. AI model/version: DeepSeek-V4.1-Flash-1017 AI usage: Assisted with implementation review, docstring wording, and Windows Sphinx warning diagnosis. Prompt summary: Verified the documentation against issue PyCalendar#1118, the implementation, and project checks.
faee463 to
235ad6c
Compare
|
Hi @TheresaYuki, let us know if you need anything. I am not sure why the tests are failing... |
Hi @niccokunzmann , thanks for checking in! I re-ran the tests just now and it seems to be working this time. |
|
@stevepiercy assigning you since it is documentation. Looks fine for me. |
AI Prompts: claude-sonnet-5-5: rfp timesheet list 1593 2026-04-3e6 1o 2026-10-27T21:30 0:09 PyCalendar/icalendar#1997 review 1594 2026-10-28T12:11 0:03 PyCalendar/icalendar#2032 review It shows an item without an MoU. add rfp edit --mou with autocomplete also batch review should make sure that the mou is assigned even if cancelled before the task is clarified claude-sonnet-5-5: rfp task list seems to not show aliases any more claude-sonnet-5-5: rfp task list should show task descriptions, too
stevepiercy
left a comment
There was a problem hiding this comment.
Looks great! No changes needed. Thank you, @TheresaYuki!
Will auto-merge when CI passes.
|
Blocked by #2092 |
Linked issue
Description
Documented the vBoolean constructor parameters and clarified the distinction between constructor values and TRUE/FALSE parsing through from_ical. The change is limited to this class.
Checklist
Additional information
The full GitHub Actions matrix and documentation checks passed. Local Windows tox failures were environment-specific. AI use is disclosed in the commit and changelog.