Skip to content

docs: document vBoolean constructor parameters (#1118) - #2032

Merged
stevepiercy merged 8 commits into
PyCalendar:mainfrom
TheresaYuki:docs/issue-1118-vboolean
Nov 11, 2026
Merged

stevepiercy merged 8 commits into
PyCalendar:mainfrom
TheresaYuki:docs/issue-1118-vboolean

Conversation

@TheresaYuki

@TheresaYuki TheresaYuki commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Linked issue

Description

Documented the vBoolean constructor parameters and clarified the distinction between constructor values and TRUE/FALSE parsing through from_ical. The change is limited to this class.

Checklist

  • I added a change log entry, following the instructions in all subsections under Change log requirements.
  • I followed icalendar's Artificial intelligence policy and disclosed my Responsible AI use in my commit messages, if applicable.
  • I added or updated tests, if applicable.
  • I ran and ensured all tests pass locally by following Run tests.
  • I added or edited documentation as necessary, both as docstrings to be rendered in the API documentation and narrative documentation, following the Style guide.

Additional information

The full GitHub Actions matrix and documentation checks passed. Local Windows tox failures were environment-specific. AI use is disclosed in the commit and changelog.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the pull request, @TheresaYuki! A maintainer will review it shortly.

@github-actions github-actions Bot added the ai-suspicion This contribution is possibly created with lots of AI help without enough human understanding. label Oct 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

One or more PR-quality checks did not pass. Review the PR Quality Checks summary in the workflow run for the failed checks and their details, then make any necessary updates.

Checklist items may remain unchecked while work is in progress. Please tick each item as you complete it.

If you used AI assistance, follow the project's Responsible AI use policy and provide the required disclosures.

Document vBoolean constructor arguments and distinguish constructor values from TRUE/FALSE parsing via from_ical.

AI model/version: DeepSeek-V4.1-Flash-1017

AI usage: Assisted with implementation review, docstring wording, and Windows Sphinx warning diagnosis.

Prompt summary: Verified the documentation against issue PyCalendar#1118, the implementation, and project checks.
@TheresaYuki
TheresaYuki force-pushed the docs/issue-1118-vboolean branch from faee463 to 235ad6c Compare October 26, 2026 11:45
@TheresaYuki
TheresaYuki marked this pull request as ready for review October 26, 2026 11:59
@niccokunzmann

Copy link
Copy Markdown
Member

Hi @TheresaYuki, let us know if you need anything.

I am not sure why the tests are failing...
It does not seem to be your fault.

Comment thread src/icalendar/prop/boolean.py Resolved
@TheresaYuki

Copy link
Copy Markdown
Contributor Author

Hi @TheresaYuki, let us know if you need anything.嗨 @TheresaYuki ,如果你需要任何帮助,请随时告诉我们。

I am not sure why the tests are failing...我不确定为什么这些测试会失败…… It does not seem to be your fault.这似乎不是你的错。

Hi @niccokunzmann , thanks for checking in! I re-ran the tests just now and it seems to be working this time.

@TheresaYuki
TheresaYuki requested a review from angatha November 2, 2026 08:36
@angatha

angatha commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

@stevepiercy assigning you since it is documentation. Looks fine for me.

niccokunzmann added a commit to niccokunzmann/nlnet-rfp-recorder that referenced this pull request Nov 6, 2026
AI Prompts:
claude-sonnet-5-5: rfp timesheet list  1593 2026-04-3e6 1o 2026-10-27T21:30 0:09 PyCalendar/icalendar#1997 review 1594   2026-10-28T12:11 0:03 PyCalendar/icalendar#2032 review  It shows an item without an MoU.  add rfp edit --mou with autocomplete also batch review should make sure that the mou is assigned even if cancelled before the task is clarified
claude-sonnet-5-5: rfp task list seems to not show aliases any more
claude-sonnet-5-5: rfp task list should show task descriptions, too

@stevepiercy stevepiercy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! No changes needed. Thank you, @TheresaYuki!

Will auto-merge when CI passes.

@stevepiercy
stevepiercy enabled auto-merge (squash) November 11, 2026 11:23
@stevepiercy

Copy link
Copy Markdown
Member

Blocked by #2092

@stevepiercy
stevepiercy merged commit ab42df8 into PyCalendar:main Nov 11, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-suspicion This contribution is possibly created with lots of AI help without enough human understanding.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants