Skip to content

test: focus ATST consumer contracts and remove duplicated plugin tests - #54

Merged
QuantumMisaka merged 4 commits into
mainfrom
fix/abacuslite-behavior-tests
Nov 16, 2026
Merged

QuantumMisaka merged 4 commits into
mainfrom
fix/abacuslite-behavior-tests

Conversation

@QuantumMisaka

@QuantumMisaka QuantumMisaka commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

ATST duplicated abacuslite parser internals and treated diagnostic wording, YAML formatting and forwarding-module size as contracts. This PR focuses tests on ATST-owned adapter and consumer behavior. Runtime code and workflow definitions are unchanged.

Changes

  • Replace the copied private frame-selector suite with three public ASE result-handoff checks: SCF force/Fermi/atom order, rejection of unrelated output, and native relaxation final forces. Keep ATST MD collection and historical import identity checks.
  • Remove duplicate STRU, backup, property-keyword and parser-reordering regressions after mapping each failure mode to the standalone abacuslite suite. Keep ATST launcher/env/version overrides and dependency error propagation.
  • Consolidate CI checks around parsed YAML and controlled shell execution: dependency selection, report handoff, release tag validation, preflight order, artifact identity and permission boundaries.
  • Replace forwarding-source length assertions with distribution module presence plus installed import-identity coverage. Preserve licensing and attribution checks.
  • Remove incidental diagnostic prose and stale historical-document assertions; translate touched comments to English. Synthetic non-English inputs remain in the language-checker tests.

Validation

  • Full isolated installed-wheel consumer suite: 1464 passed, 35 skipped, including distribution checks; installed provenance report verified. Skips require optional engines/assets. Final rebuilt wheel contents match those used by the full run; final wheel/sdist checks: 2 passed.
  • Ownership-focused scope: baseline 85 passed, candidate 27 passed, also 27 passed with published abacuslite 1.2.1. Removed cases retain owning-suite coverage.
  • CI checks plus existing consumer-runner tests: 34 passed. Equivalent YAML formatting passes; bypassed preflight, misplaced OIDC permissions and wrong artifacts are detected.
  • Wrong-force and accepted-unmatched-output mutations fail the new public ASE tests. Independent review, documentation governance and whitespace checks passed.

Paired with QuantumMisaka/abacuslite#16, whose CI pins this ATST candidate. No engine rebuild, merge or release is included.

Review follow-up

The existing developer handover now contains a compact cross-repository coverage ownership table. abacuslite PR16 fixes public output-coordinate normalization and documents simulation-box periodicity and named-stream position. Full installed ATST consumer validation against its corrected rebuilt wheel:1462 passed/37 skipped (distribution checks run separately). ATST runtime is unchanged; the private socket helper remains an explicitly separate public-API migration.

The ownership table follows the consolidated abacuslite reader contract suite; the review-specific test module was removed upstream. This follow-up changes documentation only.

@QuantumMisaka QuantumMisaka changed the title test: decouple abacuslite contracts from diagnostic wording test: focus ATST consumer contracts and remove duplicated plugin tests Nov 15, 2026
@QuantumMisaka
QuantumMisaka marked this pull request as ready for review November 16, 2026 07:03
@QuantumMisaka
QuantumMisaka merged commit 37053ea into main Nov 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant