[YoutubeBridge] Cache RSS feed URL resolution - #5081
Open
Electronic-Mango wants to merge 2 commits into
Open
Electronic-Mango wants to merge 2 commits into
Electronic-Mango wants to merge 2 commits into
Conversation
Cache RSS feed URL and icon URL when using custom name with no duration. RSS URLs for channels shouldn't change, so they can be cached for a long time.
Caching without any checks could lead to a single failed attempt blocking future feed access, until cached data expires.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using "custom name" with no specified duration, the bridge accesses the channels video page to extract RSS feed URL. Since the RSS URLs shouldn't change for channels they can be cached for a long time - in this case 30 days.
This limits hitting the actual YT webpage and should improve reliability.
When duration is specified, then cached values are not useful, as the channel videos page has to be accessed anyway.