Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Critical toolchain and rolling dependency issues must be addressed before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR migrates Linux CI and prebuild workflows to official ROS Docker images, replacing manual ROS installation.
Changes:
- Use official ROS images for x64 and ARM64 workflows.
- Simplify ROS and dependency setup.
- Update rolling, Lyrical, build, test, ASan, and prebuild environments.
File summaries
| File | Review result |
|---|---|
.github/workflows/prebuild-linux-x64.yml |
Critical (3 votes): Restore the compiler, make, and Python toolchain required by node-gyp. |
.github/workflows/prebuild-linux-arm64.yml |
Critical (3 votes): Restore the compiler, make, and Python toolchain required by node-gyp. |
.github/workflows/linux-x64-build-and-test.yml |
Critical (3 votes): Restore the native build toolchain and condition rolling-incompatible mrpt_msgs dependencies appropriately. |
.github/workflows/linux-x64-asan-test.yml |
Critical (3 votes): Restore the toolchain required by g++ and node-gyp. |
.github/workflows/linux-arm64-build-and-test.yml |
Critical (3 votes): Restore the native build toolchain required during npm installation. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 6
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| run: | | ||
| sudo apt install -y ros-${{ matrix.ros_distribution }}-test-msgs ros-${{ matrix.ros_distribution }}-mrpt-msgs | ||
| apt-get install -y --no-install-recommends \ | ||
| cmake sudo \ |
| sudo apt install -y ros-lyrical-test-msgs ros-lyrical-mrpt-msgs | ||
| apt-get update | ||
| apt-get install -y --no-install-recommends \ | ||
| cmake sudo \ |
| sudo apt install -y ros-${{ matrix.ros_distribution }}-test-msgs ros-${{ matrix.ros_distribution }}-mrpt-msgs | ||
| apt-get update | ||
| apt-get install -y --no-install-recommends \ | ||
| cmake sudo \ |
Comment on lines
+69
to
+73
| apt-get install -y --no-install-recommends \ | ||
| cmake sudo \ | ||
| ros-${{ matrix.ros_distribution }}-example-interfaces \ | ||
| ros-${{ matrix.ros_distribution }}-test-msgs \ | ||
| ros-${{ matrix.ros_distribution }}-mrpt-msgs |
| if: ${{ matrix.ros_distribution == 'lyrical' }} | ||
| run: | | ||
| apt-get install -y ros-lyrical-desktop | ||
| apt-get install -y --no-install-recommends cmake |
| if: ${{ matrix.ros_distribution == 'lyrical' }} | ||
| run: | | ||
| apt-get install -y ros-lyrical-desktop | ||
| apt-get install -y --no-install-recommends cmake |
|
coverage: 90.953%. remained the same — minggangw:use-official-ros-docker into RobotWebTools:develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.